Problem/Motivation

The web/core/modules/node/src/Plugin/migrate/source/d6/Node.php did not get the constructor updated to use ModuleHandlerInterface instead of ModuleHandler

Steps to reproduce

This is likely triggered by the hook_event_dispatcher module being enabled as well.

Run migration and receive error:
[Exec] TypeError: Drupal\node\Plugin\migrate\source\d6\Node::__construct(): Argument #7 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /code/web/modules/legacy/shop6_migrate/src/Plugin/migrate/source/ErpCore.php on line 38 in Drupal\node\Plugin\migrate\source\d6\Node->__construct() (line 81 of /code/web/core/modules/node/src/Plugin/migrate/source/d6/Node.php).

Proposed resolution

Update the constructor

CommentFileSizeAuthor
#4 3314383.patch1.33 KBsingularo
#3 3314383.patch1.31 KBsingularo

Comments

singularo created an issue. See original summary.

singularo’s picture

singularo
Location Adelaide, AUS
commented
Version: 9.5.x-dev » 9.4.x-dev
singularo’s picture

singularo
Location Adelaide, AUS
commented
StatusFileSize
new 3314383.patch1.31 KB
singularo’s picture

singularo
Location Adelaide, AUS
commented
StatusFileSize
new 3314383.patch1.33 KB

Need core directory.

cilefen’s picture

cilefen commented
Version: 9.4.x-dev » 9.5.x-dev
dpi’s picture

dpi
Location Perth, Australia
commented

Constructor is changing which will break inheritance, needs a CR?

Patch looks good.

dpi’s picture

dpi
Location Perth, Australia
commented

Hiding defective patch

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented

Rerunning tests. Though I'm 99% they were random failures.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs change record

Also think this looks good but agree with @dpi this will need a change record.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

+1 RTBC for this issue

Putting to review for the change record which I primarily pulled from the description and title.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

added change record.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3314383.patch, failed testing. View results

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue tags: +migrate-d7-d8
quietone’s picture

quietone commented
Status: Needs work » Postponed
Issue tags: -migrate-d7-d8 +migrate-d6-d8

The Migrate Drupal Module was approved for removal in #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3522602: [meta] Tasks to remove Migrate Drupal module and the removal work in #3522602: [meta] Tasks to remove Migrate Drupal module.

Migrate Drupal will not be moved to a contributed project. It will be removed from core after the Drupal 12.x branch is open.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Postponed » Closed (duplicate)
Related issues: +#3512815: "core/modules/node/src/Plugin/migrate/source/d6/Node.php" "__construct" method uses variable of type "ModuleHandler" instead of "ModuleHandlerInterface"

This was fixed in #3512815: "core/modules/node/src/Plugin/migrate/source/d6/Node.php" "__construct" method uses variable of type "ModuleHandler" instead of "ModuleHandlerInterface", I have updated credit.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.