Problem/Motivation

This is a followup to #2890613: Erroneous Unresolved dependency with missing version in info file. The goal is to add a useful message when a module does not have a version property and other modules depend on it, potentially needing a specific version. A module will not have a version property if it was obtained via git or a dev version was obtained via composer.

Steps to reproduce

  1. composer require drupal/linkit:5.x-dev
  2. composer require drupal/linkit_media_library
  3. go to admin/modules

Proposed resolution

Display a precise & actionable error message.

Remaining tasks

Add useful error message

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 interdiff_8_11.txt854 bytesameymudras
#11 3300838-11.patch6.55 KBameymudras
#10 reroll_diff_4_10.txt2.31 KBtvb
#10 3300838-10.patch6.06 KBtvb
#8 interdiff_7-8.txt2.03 KBpooja saraah
#8 3300838-8.patch6.47 KBpooja saraah
#7 interdiff_4_7.txt7.98 KBameymudras
#7 3300838-7.patch5.85 KBameymudras
#4 2890613-21.patch6.02 KBquietone

Issue fork drupal-3300838

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone credited mkalkbrenner.

quietone credited oknate.

quietone’s picture

quietone commented
Issue summary: View changes
Issue tags: +Bug Smash Initiative, +Needs reroll
StatusFileSize
new 2890613-21.patch6.02 KB

This is the latest patch from the other issue, which needs a reroll. Adding tag.

Adding credit from the other issue as well.

devashish jangid’s picture

devashish jangid commented
Assigned: Unassigned » devashish jangid
ameymudras’s picture

ameymudras commented
Assigned: devashish jangid » Unassigned
ameymudras’s picture

ameymudras commented
Status: Active » Needs review
StatusFileSize
new 3300838-7.patch5.85 KB
new interdiff_4_7.txt7.98 KB

Adding a re rolled version of the above patch

pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 3300838-8.patch6.47 KB
new interdiff_7-8.txt2.03 KB

Fixed Failed commands on #7
Attached patch and inderdiff file.

Status: Needs review » Needs work

The last submitted patch, 8: 3300838-8.patch, failed testing. View results

tvb’s picture

tvb commented
Issue tags: -Needs reroll
StatusFileSize
new 3300838-10.patch6.06 KB
new reroll_diff_4_10.txt2.31 KB

Rerolled patch.

1 merge conflict in core/lib/Drupal/Core/Extension/ModuleDependencyMessageTrait.php

ameymudras’s picture

ameymudras commented
Status: Needs work » Needs review
StatusFileSize
new 3300838-11.patch6.55 KB
new interdiff_8_11.txt854 bytes

@tvb I don't think that is required the patch #8 applies cleanly for Drupal 9.5.x.

Adding another patch to fix the test for #8.

Status: Needs review » Needs work

The last submitted patch, 11: 3300838-11.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

nicxvan’s picture

nicxvan commented

This needs a reroll and a conversion to an MR.

mrinalini9 made their first commit to this issue’s fork.

mrinalini9 opened merge request !12619

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

nicxvan’s picture

nicxvan commented

Can you please address the code sniff and php stan failures?

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.