Problem/Motivation

The change introduced in #2136559: Config entity admin lists show configuration with overrides (eg. localized) makes the site administration confusing/harder is some situations.

Steps to reproduce

Real life example:
- Site should be German
- Many of the site developers do not speak German
- Site editors (the client) do not speak English. Showing any English text to the site editors is not desired.
- The site editors can manage taxonomy terms, can access vocabulary listing page, but can't edit vocabularies

To make everyone's life easier, the site is configured as
- config is translated from English to German
- developers understand that the config edit form shows the config in source language
- developers can switch the language, and use Drupal in English
- site editors can use Drupal in German language only

The problem:
- site editors see vocabulary names in English on the vocabulary listing page

Proposed resolution

Make the config listing language configurable.
Allowed language options:
- Config source language (This is how it works currently)
- Current language (The proposed new option)

Or to make it technically accurate, the options should be:
List config entities:
- without config overrides
- with config overrides

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3281219

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Pasqualle created an issue. See original summary.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented

The same applies to menus

sleitner’s picture

sleitner commented

I suppose, the option to list the config entities should be per user

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

Not necessarily.
By default, the config listing should use the language which makes more sense for the site. The current behaviour "without override" or the new "with override" option. If the current language does not work for some users, then those users should have the option to change the current language with the language switcher.

Not sure about your use case, but if there is a need for more granular setting, then I would prefer the option to be "per list". Like most of the config lists can be displayed with override, but the date formats are displayed without override (as that was the original issue when the config listing behaviour was changed).
Maybe there could be a switch to on every config listing to show the list with or without overrides.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mohit_aghera opened merge request !4979

mohit_aghera made their first commit to this issue’s fork.

mohit_aghera’s picture

mohit_aghera commented

I came to this issue while I was trying to fix https://www.drupal.org/project/drupal/issues/3030949

It seems that current implementation done in https://www.drupal.org/project/drupal/issues/2136559 has valid reasion and done on purpose.
Still if someone needs the changes, I've tried small workaround by using a flag to see if we can control whether we want to load an entity override free or not.
Let's see how test suite goes.

smustgrave credited belyj_vladislav.

smustgrave’s picture

smustgrave commented

Closed #3030949: Config entity label and other fields translation doesn't work on some pages moved over credit from original author who worked on it in D8

Not sure if the rerolls need to be brought over.

dieterholvoet’s picture

dieterholvoet commented
Title: Language used for config listing should be configurable » Loading config overrides (e.g. translations) in listings should be configurable

This can also be useful in non-translation contexts. For example, the domain overview now lists all domains without config overrides. I however override domains in local environments in settings.php, and it would be useful if the current, local domain were shown instead of the default.

ivnish’s picture

ivnish
he/him
commented

@DieterHolvoet is MR ready to test/review ?

dieterholvoet’s picture

dieterholvoet commented

I think so, but not sure. It's been a while.

ivnish’s picture

ivnish
he/him
commented
Status: Active » Needs review

Let's check the status

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Seems like something that should have test coverage

ivnish’s picture

ivnish
he/him
commented

I tested this patch manually and I don't understand how it works

I created a site as in steps for reproduce. I installed a patch

The German users still see vocabulary name in English

@dieterholvoet What i missed?

oily’s picture

oily commented
Issue tags: +Needs issue summary update

The steps to reproduce need to be redefined. They illustrate the problem currently.

thatguy’s picture

thatguy commented

The MR seems to work, as an admin user I now see the admin/structure/menu page with the translated menu names and descriptions which was my problem.

Seems to me that this flag introduced in the MR should be a togglable config option.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.