generate sample values get dimensions wrong when min_resolution is bigger than 600x600

Tagging as novice.

Task: Apply the patch (ask mentors if you need help). See if it applies.

If it does apply: See if it does what it says it does and report back with screenshots.
If it does not apply: Report any error messages you get, and change the status to "Needs work".

The previous patch had some Coding Standard errors.

I was either unable to reproduce the bug or the bug doesn't exists (maybe I just didn't follow the right steps).

I created a new content type with only one field (a required image field with min resolution of 600x600), then, without the patch code, ran Devel generate to create some content from this new content type I just made. All the images had the correct size.

Changing status as this issue already have a patch.

Thanks @andregp! Untagging as novice as it sounds like more investigation needs to happen.

Thanks for the clarification @guiu.rocafort.ferrer!

Sending to Needs Review as we already have a patch with a possible solution and the Active status is used only when there's no patch attached (reference here).

Adding back Novice tag as it's a simple review.

Hello,

I applied Patch #3 and confirmed it works now.

Please see attached files.

Thank you.

Can we get some tests of this so there is no regression? There is an existing test \Drupal\Tests\image\Kernel\ImageItemTest that looks like it can be used. I am adding the "needs tests' tag.

This still needs a test.

Thanks for the tests. Just FYI for next time when adding tests it helps to upload a test-only patch followed by the full patch. Also an interdiff between patches.

But I ran the tests locally without the fix and it failed as expected

Failed asserting that 709 matches expected '800'.
Expected :800
Actual :709

Crediting @rootwork for mentoring, @quietone for a review and @smustgrave for running the test locally

Committed 4578bbd and pushed to 11.x. Thanks!

Backported to 10.1.x. Not backporting any further because 9.5.x and 10.0.x are now in security only mode.

Fixed on commit (comment was > 80 chars).

diff --git a/core/modules/image/tests/src/Kernel/ImageItemTest.php b/core/modules/image/tests/src/Kernel/ImageItemTest.php
index 037a6378300..a1879bb4428 100644
--- a/core/modules/image/tests/src/Kernel/ImageItemTest.php
+++ b/core/modules/image/tests/src/Kernel/ImageItemTest.php
@@ -155,7 +155,7 @@ public function testImageItem() {
   }
 
   /**
-   * Tests generateSampleItems() method under different min_resolution and max_resolution configurations.
+   * Tests generateSampleItems() method under different resolutions.
    */
   public function testImageItemSampleValueGeneration() {