Drupal 10 readiness meeting / 21 March 2022 [#3268232]

Meeting will happen in #d10readiness on drupal.slack.com.

Hello and welcome to this Drupal 10 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Now happens every Monday at 19:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3268232`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

xjm	:wave: xjm, Drupal core release manager, enjoying the unexpectedly springlike second day of spring
shaal	:blob_wave: Ofer Shaal, DrupalPod, Umami
catch	Nat, not really here yet.
Gábor Hojtsy (he/him)	Gábor, Drupal 10 coordinator
keboca	keboca - backend - :flag-cr:
kimb0	Kim AU
quietone	Hi
dww	Derek, US
el7cosmos	hi
Ilcho Vuchkov (vuil)	Ilcho Bulgaria
Kristen Pol (she/her)	Kristen, California

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

murilohp

I don't know if it's something to be addressed here, but I have the issue bellow, it's a bug and the solution was pushed to 10.x branch, but due to a wrong test(my fault, sorry), the solution is not on 9.x branch, now I think I've properly fixed the test and I need a review there, and the test on 10.x branch need to be updated[#3255887] (edited)

2️⃣ We are targeting the Drupal 10 release window in August, if beta requirements are done by mid-May. We need your help to get these things done in time! Sub-threads below for specific topics you can help with! (edited)

2️⃣ . 1️⃣ Help needed on blockers for stabilizing CKEditor 5 in core (edited)

xjm	Meta: #3238333: Roadmap to CKEditor 5 stable in Drupal 9
xjm	#3261585: Remove IE11 warning for CKEditor 5 in Drupal 10, since Drupal 10 does not support IE anyway could use review

2️⃣ . 2️⃣ Removing CKEditor 4 from core. Drupal 10 beta blocker. (edited)

xjm	@catch and I discussed this, and agreed that even though CKEditor 5 is not stable yet, we can start to make tests and so forth use CKEditor 5 instead of 4
xjm	New meta at #3270437: [meta] Tasks to deprecate the CKEditor 4 module
xjm	A child issue needs to be filed to move the Media and Media Library integrations for CKEditor for into the CKEditor module (but be careful not to move the CKEditor 5 integration along with it!)

2️⃣ . 3️⃣ Help needed on JavaScript dependency changes required for Drupal 10

xjm	Meta: #3238507: Drupal 10 JavaScript dependency plan
xjm	PostCSS issue #3261163: Update to PostCSS 8 needs review
xjm	#3270395: Remove use of underscore from editor.admin.js and filter.filter_html.admin.js has some work done. There is more still to be done. The IS has the documented replacements to use if you know at least a bit of JavaScript.
murilohp	Regarding #3270395: Remove use of underscore from editor.admin.js and filter.filter_html.admin.js, do you know how we could properly replace the difference function from underscore?
xjm	Someone hopefully does. I am not someone who knows even a bit of JavaScript. :wink: My JavaScript skills peaked in 2003. :smile:
xjm	So another way someone who does know JS could help with the issue is to suggest a pattern for replacing _.difference() :joy:

2️⃣ . 4️⃣ Removing Aggregator. Aggregator is a Drupal 10 beta blocker.

catch

#3270323: ModuleConfigureRouteTest::testModuleConfigureRoutes fails for modules which have a configure route and are deprecated needs review. Should be the final blocker to the deprecation and removal issues both of which have patches.

2️⃣ . 5️⃣ Removing QuickEdit core. QuickEdit is the the next priority because it reduces the scope of required D10 JavaScript dependency work.

xjm	#3265140: Move QuickEditImageController from image to quickedit has some initial work but needs more. Next steps: moving some files, updating namespaces,
dww	I also started looking at #3267258: Remove Quick Edit support from editor.module. There’s a route in editor.routing.yml that on first glance is unused, but closer digging it looks maybe used in some JS / AJAX code. I haven’t fully wrapped my head around it.This work would sure be easier if the original QE authors / maintainers were helping, even just some simple advisory guidance, instead of everything having to be reverse engineered by folks like me that have never looked at any of this code until now.
xjm	Unfortunately the original authors of QuickEdit are also in the critical path for CKEditor 5 which is the thing most likely to make us miss the May beta deadline (edited)
xjm	But I can put it on our internal backlog to see if they could provide feedback if they have time.
xjm	@dww I suspect this route is used to allow WYSIWYGs to be rendered inside QuickEdit for fields that support WYSIWYG, but do not actually know for sure :slightly_smiling_face:
xjm	@dww The obvious thing would just be to move both the route and the controller to QuickEdit, and check for any potentially related JavaScript inside Editor's directory as well
xjm	There is definitely also at least one test that tests the integration between Editor and QuickEdit
xjm	So that could be a place to look to see how it works
mstrelan	From memory there is some js in editor or image module that references the path to the route, but no references to the route by its name
dww	That’s what I discovered. Just haven’t tried to understand the js yet to figure out wtf it’s about..
mstrelan	I don't have time to look now (or for a while) but I recall linking to an issue where the js was introduced, which should give an idea what it's for. If you can't find that link I found it originally by doing a git blame on the js file.
mstrelan	Never mind, that was for the image module issue rather than the editor module issue.
dww	All good. Thanks for the help and pointers, regardless. I think I’ll be able to figure it out when I have time to really dive in. Was mostly wishing out loud for some more support from the original authors / maintainers so it could all go faster... :wink:

2️⃣ . 6️⃣ Removing Color core. Color is the the next priority because it reduces the scope of required D10 JavaScript dependency work.

xjm

The policy is RTBC #2808151: [policy] Move the Color module to a contributed project when Bartik is deprecated -- Next step is to file the implementation meta. Some work will need to be postponed until Olivero replaces Bartik in Standard, but other stuff like investigating integration tests etc. we can start investigating now

2️⃣ . 7️⃣ Removing other modules we are planning to remove: Forum, Tracker, and RDF remaining.

xjm	It looks like Forum #3261652: Deprecate Forum module in Drupal 10 needs an issue split off for Help Topics
xjm	For RDF #3267513: Handle migration tests for removing RDF is NR
xjm	Similarly so is #3267314: Handle migration tests for removing tracker for Tracker

2️⃣ . 8️⃣ Making Olivero the default theme of Standard will allow us to deprecate Bartik and Color!

xjm	#3219958: [META] Make Olivero the default theme is the meta
xjm	#3260592: Change Bartik-specific tests to Olivero (or appropriate alternative) in preparation for making Olivero the default seems like an easy place to help, just look for tests that use Bartik and work on switching them
xjm	Meanwhile #3210747: QA testing of Olivero - Desktop browser: Safari are both needs review; I'm not sure what needs to be done there -- child issues filed for bugs? etc. /cc @mherchel again. What's the next step when they are NR?
mherchel	will respond shortly!

2️⃣ . 9️⃣ Claro!

xjm	Meta: #3066007: Roadmap to stabilize Claro
xjm	Sorry, deleting messages from wrong thread :stuck_out_tongue:

2️⃣ . 🔟 Starterkit!

xjm	Several child issues of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore need review and that'd be a great way to help :slightly_smiling_face:
danflanagan8	We got the following issue to RTBC this past weekend. It's going to help with many of the remaining modules that still need the Classy-to-Stark work. #3268932: Add methods to assert status messages to WebAssert