Background

This issue is being split off from and is dependent on #3177296: [META] Make Olivero stable. The goal of this issue is to track, and identify issues that are needed to set the Olivero to be the default theme for Drupal.

Must-haves

Done

Should-haves

Accessibility

Features

Bugs

CommentFileSizeAuthor
#27 FRed2WhVkAEPG1o.jpeg105.99 KBmherchel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Issue summary: View changes

Adding #3224750: Figure out how to handle views grid in Olivero

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer and at Acquia commented
Issue summary: View changes

Adding #3230435: Makes sure Olivero JS is a small as possible here because it's only necessary when we flip the switch on the default theme, not to make the theme stable.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue tags: +Needs product manager review, +Needs release manager review, +Needs frontend framework manager review

Adding some tags.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes

Moving #3173877: [meta] QA testing of Olivero across multiple browsers to this issue, I don't think the last couple of browsers should hold up marking Olivero stable in 9.3, but it'd be good to be sure we've gone through everything prior to making it the default?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue summary: View changes

Agreed! Fixing the notation so it is properly included.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer commented
Title: [META] Make Olivero the default theme for Drupal 9.3 » [META] Make Olivero the default theme for Drupal 9.4

Adjusting title, since 9.3 released

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Title: [META] Make Olivero the default theme for Drupal 9.4 » [META] Make Olivero the default theme for Drupal 10
Version: 9.4.x-dev » 10.0.x-dev

Not sure if this'll make Drupal 9, but come hell or high water, It'll be in Drupal 10.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 10.0.x-dev » 9.4.x-dev

Still time to get this into 9.4.0, so moving back to there.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Issue summary: View changes

Adding #3260592: Change Bartik-specific tests to Olivero (or appropriate alternative) in preparation for making Olivero the default

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

There are a number of accessibility issues on #3177296: [META] Make Olivero stable that were described as:

Should-have issues for stable release / settings as default theme:

Should they be added to the IS here? Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes

Added the should-haves from the previous meta.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes

(Removing issues that have been closed in the interim.)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Issue summary: View changes

Removing #3227431: Tabledrag icon doesn't adapt to forced-colors mode, as this issue is no longer Olivero specific.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes

The fact that it came up in an a11y review is still a reason to keep it as a should-have (even if it's not a must-have). :)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes

New one, seems at least should-have: #3270574: Olivero comment template breaks 'new' indicator/anchor

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

#3173877: [meta] QA testing of Olivero across multiple browsers was just marked complete based on the remaining Safari work done, so #3219959: Update standard profile so Olivero is the default theme is the only must have left.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -Needs product manager review

As a Drupal core product manager, I approve of Olivero becoming the default. The amount of improvements this has over Bartik is immense. I don't believe there are any missing pieces or problems from a product perspective for a default theme that will be a big step up from Bartik.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Title: [META] Make Olivero the default theme for Drupal 10 » [META] Make Olivero the default theme
Issue tags: -Needs frontend framework manager review

Went through the queue and discussed with @ckrina at DrupalCon Portland 2022 and we agreed that after the roadmap in the issue summary has been resolved, Olivero can be marked as the default theme in Standard.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue tags: -Needs release manager review

All of the blockers (except the actual issue to make Olivero the default) are done, and most of the should haves are either done or need review, so happy to remove release manager review tag here. A lot of other bugfixes and features have landed since the theme marked was marked stable that didn't get explicitly listed in this issue too, which is a good sign in general.

I've also been using a subtheme (shh) of Olivero for a personal project, and have been really impressed (also found and posted a couple of bugs).

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue summary: View changes
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: +Portland2022

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Active » Fixed
FileSize
FRed2WhVkAEPG1o.jpeg105.99 KB

Olivero is the default (as of trivia night at DrupalCon Portland!

Picture from @Gábor Hojtsy's tweet at https://twitter.com/gaborhojtsy/status/1519858022603890690

Photo of live commit from DrupalCon Portland 2022

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.