Media items translate items in modal

This is going to need UI work for all related Media editing issues.

Hi @mschudders,
Due to some platform limitations I have on the project, I can't update drupal core further than 9.3 atm, so I have rerolled the patch for that version. Thanks for the patch you created.

Whoops, there was an issue with paths in the patch above, fixed it here.

A quick review after using the following patches with Drupal 9.4.8:

• "2985168: Allow media items to be edited in a modal when using the field widget": "https://www.drupal.org/files/issues/2022-03-03/2985168-121.patch",
• "3266293: Media items translate items in modal": "https://www.drupal.org/files/issues/2022-07-19/3266293_translate_button_..." from comment #13 above

I don't know if it needs stating, but the entity bundle's content translation option "Hide non translatable fields on translation forms" is not enabled.

When editing a translation of the parent entity when the media entity does not yet have a translation of the same language,

• I see the media entity reference field display the media image thumbnail with edit and translate buttons above the preview.
• Clicking the edit button allows me to edit the media entity's source translation
• Clicking the translate button allows opens modal with modal title of "Create [Language] translation of [Media Name]" and create a translatiom of the media entity, e.g. removing image and uploading new image, etc.
• However, after clicking save within the translate modal, the parent entity's media reference field widget is not updated to show the new translation. Instead, it continues to show the media entity's source translation. Is this expected behavior?
• Reloading the page will update the preview with the new translation

If the "Hide non translatable fields on translation forms" option is enabled, when editing a the source language of the parent entity

• I see the media entity reference field display the media image thumbnail with edit button above the preview.
• I do not see a translate button above the preview. Is this expected behavior?

I'm not sure what to expect, but I thought I'd share my experience so far.
If the "Hide non translatable fields on translation forms" option is enabled, when editing a the source language of the parent entity

After getting the same experience as jasonawant from comments in #17

My solution for now was to use the patches from #17 then also enable Media Library Edit. (You have to enable 'Show edit button' in the reference field form widget). At this point I have an edit and translate button from patches in #17 (with issues such as not loading the correct language of media when on a translated node page) and another edit button from the media_library_edit module.

I then create a custom module to add css to my admin theme with hook_page_attachments to add css.

.js-media-library-widget input.edit-media {
  display: none;
}
.js-media-library-widget input.translate-media.button {
  display: block !important;
}

Im hiding the edit media button from the patches in #17, but still showing the translate media button when necessary (it only shows up when a media has no translation yet). Then using the media_library_edit edit media button as the only way to edit media on a node reference form. Messy, but seems to work.

Re rolling patch to work with latest in "2985168: Allow media items to be edited in a modal when using the field widget" : https://www.drupal.org/files/issues/2023-01-19/2985168-media-edit-modal-...

Seems to work with 9.4.x and 9.5.x .. but again still need the latest patch from issue #2985168

Adding a re-rolled patch to make it compatible with "2985168: Allow media items to be edited in a modal when using the field widget": https://www.drupal.org/files/issues/2023-12-18/2985168-172.patch.

This patch works with Drupal 10.2.x.

#22 Also applies to 10.3.x

I couldn't use issue fork, since this code needs to be applied on top 2985168: Allow media items to be edited in a modal when using the field widget .

Attached is an updated patch that works with Drupal 11.2.5.

We really do need changes in an MR for review.

This is also still postponed!

> I couldn't use issue fork, since this code needs to be applied on top 2985168: Allow media items to be edited in a modal when using the field widget .

You can pull the branch from another MR into your fork, and then put your branch on top of it.

The patch in #25 doesn't apply any more.

Attached is an updated patch.

Here is a version of #29 which is compatible with Drupal 11.3.2

(There was a tiny change replacing "todo:" with "todo" which caused the patch to not apply.)