Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The visually hidden text describing a toolbar buttons purpose has unnecessary parentheses and curly braces at the end. The screen readers I tested include the curly brace in their announcement, so this is more than cosmetic
Steps to reproduce
Proposed resolution
Remove that punctuation.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3258668-6-d10.patch | 1.46 KB | bnjmnm |
| |||
| Screen Shot 2022-01-14 at 2.15.57 PM.png | 100.03 KB | bnjmnm | |
Issue fork drupal-3258668
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3258668-extraneous-closing-parentheses
changes, plain diff MR !1672
1 hidden branch
Comments
Comment #2
Wim LeersWow, what a find! 😅
If this is , should it also be a stable blocker? 🤔
Comment #4
Wim LeersFYI: this fix is also present in #3218297, see #3218297-9: Voiceover + Safari reads aria-describedby twice when focusing toolbar button.
I'm fine with this going in as-is (hence RTBC) or for this to get marked as a duplicate of that one. I'll let @bnjmnm and @lauriii decide.
Comment #5
lauriiiWould it be possible to get a patch for Drupal 10? 🙏
Comment #6
bnjmnmD10 patch attached.
Comment #7
lauriiiThis looks good! This can be committed after the freeze 👍
Comment #12
lauriiiCommitted 9a98b09 and pushed to 10.0.x. Committed the MR in 9.4.x and cherry-picked to 9.3.x because CKEditor 5 is experimental, and this is a low risk change. Thanks!