Problem/Motivation

#3228634: Move tests for integrations between QuickEdit and other modules into QuickEdit so that it can more easily be moved into contrib moved all known QuickEdit integration tests into the QuickEdit module, but we missed some methods:

- Remove quickedit annotation from test formatter plugin TestTextTrimmedFormatter.php (Relevant commit message, exhibit A)

- Remove quickedit annotation from test formatter plugin DummyImageFormatter: (Relevant commit message, exhibit B)

Proposed resolution

Alter the test to decouple it from QuickEdit.

AKA: Steal the commits made by @dww in the parent issue.

Remaining tasks

TBD

Issue fork drupal-3231071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !1151

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Priority: Normal » Major
Status: Active » Needs review
Issue tags: +Drupal 10
spokje’s picture

spokje
Primary language Dutch
commented
Parent issue: #3227033: Remove Quick Edit from core » #3228986: [Meta] Tasks to deprecate Quick Edit
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

MR is reporting as not mergable.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll

Looking at the commit I just merged from HEAD of 9.3.x I'm pretty sure @catch looked at #2 for the not mergable message.

This is/was however the status when I (mistakenly) opened the MR before committing any changes in it.
Sadly that status appearantly never gets updated by GitLab/d.o/The Byte Pixies and stays forever unmergeable even when the _current_ status, as can be seen in the MR report below the IS and the latest testrun shown on the bottom of the issue are all green. :/

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

It looks like that @Spokje is right... The MR is mergeable. I merged 9.3.x into 3231071-remove-quickedit-from locally and no conflict were triggered.

Btw the patch looks good so I'm moving to RTBC. I won't rebase the branch again as @Spokje already did it on #5.

larowlan made their first commit to this issue’s fork.

  • larowlan committed 1819100 on 9.3.x authored by Spokje 
    Issue #3231071 by Spokje: Remove QuickEdit from the test formatter...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Thanks folks, merged cleanly this time

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.