Olivero: Site name should not have url to homepage in maintenance mode.

On maintenance page, we have URL to homepage on the Site name. but when we're already in maintenance mode, is it beneficial to have it?

CommentFileSizeAuthor
#4 3226003_Afterpatch.png70.52 KBhmendes
#3 3226003-after_patch.png204.36 KBabhijith s
#3 3226003-before_patch.png74.57 KBabhijith s
#2 3226003-2.patch687 bytesgauravvvv
Screenshot 2021-07-30 at 2.11.25 PM.png203.86 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3226003-2.patch687 bytes

I have provided a patch. Please review.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3226003-before_patch.png74.57 KB
new 3226003-after_patch.png204.36 KB

Applied patch #2 and it worked fine. The <a> tag is removed from the template in this patch,which I think is the best way.

Before patch:
before

After patch:
after

RTBC +1

hmendes’s picture

hmendes commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3226003_Afterpatch.png70.52 KB

Hello, I tested this issue locally and the patch from #2 fixed it.
Steps:

  • Put your site on maintenance mode on /admin/config/development/maintenance
  • Log out of your site
  • Without the patch, the site name will be a link to the site home page
  • With the path, it will only show the site name but it won't be a link

Changing it to RTBC.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Closed (outdated)

Closing this in favor of #3194560: Style maintenance page for Olivero