Olivero Meeting 2021-05-10 [#3210715]

Meeting Agenda

Introductions
Status and what's next
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Notes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every other Monday at 2pm UTC (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3210715: Olivero Meeting 2021-05-10

Andy	:wave: hello
mherchel	:wave:
hansa11	Hello :wave:
starshaped (she/her)	Hi all!
thejimbirch	Good Morning!
markdorison	Morning!
anjalivijay	Hello :wave:
Neslee	Hi :wave:
atul4drupal	:pray:
AmyJune (volkswagenchick she/her)	Hello from Northern California!
Sakthivel	Hi Good Morning all
kiran.kadam911	Hello
Sarah Corbine	Hi
gaurav mahlawat	Hello :wave:
Kunal Kapoor	Hi :wave:
brianperry	Hi! Thought this was an off week meeting wise - will check in on threads in a bit.
shaal	:wave:
sd9121	Hello
anmolgoyal74	Hello
mansoor20	Hi :wave:

1️⃣ Status and what's next

mtift	This tread is for discussing the overall status of the Olivero initiative and where we're going in broad terms. We'll save specific issue discussions for later threads.
mherchel	#3177296: [META] Make Olivero stable
mherchel	We’ve made some progress. All of the stable blocking bugs are completed
mherchel	we had a bump in the road with testing, where our testing implementation wasn’t quite right. We’re working on that. See #3174107: Add additional testing coverage for Olivero
mherchel	We have a number of issues open and needs review for some JS coding standards. Making progress on these, but still a ways to go. See #3153234: [Meta] Olivero JavaScript should be selecting [data-drupal-selector] attributes where possible
mherchel	We’re also making progress on some tech debt issues by converting various CSS to BEM style instead of using the cascade.
mherchel	Only two stable blocking accessibility issues left, and one should be ready to go (still needs review though)
AmyJune (volkswagenchick she/her)	Some Kanopians have Contribution time this week, I’ll check in with them about their JS skills.
mherchel	Thanks! Also ask about their writing tests skillz

2️⃣ Individual issue discussion

mtift	This thread is the place to bring up specific issues that need some extra discussion
mherchel	@brianperry @mtift @mglaman Is there any way that I can better support you on #3174107: Add additional testing coverage for Olivero ?
mtift	@mglaman and @brianperry have both made good progress on converting the unit tests
kiran.kadam911	Any guide on this: #3185067: Under certain circumstances the primary navigation can create horizontal scrollbar
mherchel	I honestly haven’t had time to take a look at it. To me, its extremely edge case, with a lot of downsides if we don’t do it properly. I’ve been working on stable blocking issues.
mtift	Regarding tests, I think it will just take some time to get them converted. By my count the conversion is half-way done with more work in progress
mherchel	Do you need more people? I can try to round some up
mtift	No, I don't think so. Matt and Brian have already claimed the remaining tests
mherchel	OK
mtift	It took more than a month, including code sprints, to get the tests written initially. It's only been 1 week since we learned that they need to be converted, so I think this actually really good progress :slightly_smiling_face: (edited)
mherchel	it is.
mherchel	and it’s a bummer that we need to rewrite them
mherchel	i’m just really trying to make stable by 9.2, but it seems that for every step forward its been two steps back
mtift	Sorry, Mike. I know that can be frustrating.
brianperry	Yeah, I think Matt and I mainly need to finish out the tests that we have in flight. I'm mostly done with the one remaining test I have for preprocess_input and then will review and see where I can help with what remains of Matt's stuff. Expect to have some time today.
brianperry	@mherchel re: help - review is probably the big thing. Both once we're done obviously, and also checking in now to make sure we aren't off track like last time would help. I pinged @alexpott to see if he had some time for that previously.
mherchel	OK.
mherchel	@larowlan would you be willing to make sure we’re on the right track with #3174107: Add additional testing coverage for Olivero also?
brianperry	Also if someone has time to lend a hand, the specific issue about $form['actions'] referenced in #3174107: Add additional testing coverage for Olivero#comment-14091227 I'm assuming is a bugfix that should be made on this branch as well.
brianperry	I'd imagine we'd need a test for that as well, but should be separate enough from the other things in flight.
brianperry	@atul4drupal See above for something that should be a pretty isolated task on that testing issue if you have availability.
atul4drupal	@brianperry Sure will see if I can help :slightly_smiling_face:
mtift	Thank you so much for all of your work on testing, Brian!
brianperry	Np - want to see this one cross the finish line as much as everyone else does :slightly_smiling_face:
rachel_norfolk	Oh - think I just found a new one! #3213214: Is Olivero missing an ID on comments?

3️⃣ Where can people help this week?

atul4drupal	Was thinking of helping with Test coverage issue but seems that is already taken up...
kiran.kadam911	@mherchel Need review, Can you pls help here to go-ahead whenever you get time to look on. Thanks in advance!#3200584: Olivero's focus state outline can get cut off certain situations#comment-14077158
mherchel	Need lots of reviews:#3208372: Olivero: Refactor comments.es6.js

Participants:

Andy, mherchel, hansa11, starshaped (she/her), thejimbirch, markdorison, anjalivijay, Neslee, atul4drupal, AmyJune (volkswagenchick she/her), Sakthivel, kiran.kadam911, Sarah Corbine, gaurav mahlawat, Kunal Kapoor, brianperry, shaal, sd9121, anmolgoyal74, mansoor20, mtift, rachel_norfolk

Issue fork drupal-3210715

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3210715-olivero-meeting-2021-05-10 changes, plain diff MR !666
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

26 April 2021 at 13:07

mtift created an issue. See original summary.

Comment #2

26 April 2021 at 13:07

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.