Postponed on #3258435: Remove deprecated feed.reader.* and feed.writer.* services from the container

Problem/Motivation

Most of these words are used once in a single file, some are in two files.
archiver
atomentry
atomfeed
atomrendererfeed
chainedfast
checkboxradio
configentity
configurator
contententry
contentrendererentry
controlgroup
derivedfrom
dublincoreentry
dublincorefeed
dublincorerendererentry
dublincorerendererfeed
itunesentry
itunesfeed
itunesrendererentry
itunesrendererfeed
kinberg
linkback
lrdd
mattfarina
phpserialize
pingback
podcastentry
podcastfeed
preconnect
refback
robloach
sayre
slashrendererentry
slatkin
threadentry
threadingrendererentry
timegate
timemap
trackback
webmention
wellformedwebentry
wellformedwebrendererentry

Remaining tasks

Review

Issue fork drupal-3210125

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

StatusFileSize
new3.69 KB

Not testing yet.

Is this the way to go for these files?

quietone’s picture

Issue summary: View changes
longwave’s picture

This looks nicely self contained, I hope this is an easy win to get in.

+++ b/core/core.link_relation_types.yml
@@ -1,5 +1,7 @@
+# cspell:ignore derivedfrom kinberg linkback preconnect refback sayre slatkin
+# cspell:ignore timegate timemap trackback webmention pingback lrdd

Let's put these in alphabetical order.

rakesh.gectcr made their first commit to this issue’s fork.

rakesh.gectcr’s picture

Assigned: Unassigned » rakesh.gectcr

rakesh.gectcr’s picture

Hi all, Please forgive, after a long time, back into issue queues. First time working with drupal core issue forking workflow. So please advise. Sorry for the mess up on the branch.

However, I have addressed the changes suggested by @longwave.

Please review.

Thanks,

Kind regards,
Rakesh James

rakesh.gectcr’s picture

Assigned: rakesh.gectcr » Unassigned
Status: Active » Needs review
quietone’s picture

Issue summary: View changes
StatusFileSize
new6.42 KB
new9.04 KB

HI rakesh.gectcr, thanks for the updates.

Since longwave likes this method, I have added two words for two more files, core.libraries.yml and and core.services.yml. I've also added a couple of words from those words that appear in two files. There are words in these files that will require changes in 3 or more other files and that just seems too much. It is always a guess but this seems like a nice set of words.

Not much a fan of gitlab workflow so this is a patch.

quietone’s picture

StatusFileSize
new9.2 KB
new697 bytes

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Issue summary: View changes
StatusFileSize
new2.97 KB
new8.63 KB

Rerolling for 9.3.x. Removed the changes to popperjs because I was getting a failure is a .js file and I don't know how to work with js files.

longwave’s picture

  1. +++ b/core/core.libraries.yml
    @@ -1,5 +1,7 @@
    +# cspell: ignore checkboxradio controlgroup mattfarina robloach
    

    I think there should be no space betweeen cspell: and ignore.

  2. +++ b/core/core.link_relation_types.yml
    @@ -1,5 +1,8 @@
    +# cspell:ignore derivedfrom kinberg linkback lrdd pingback preconnect preload
    +# cspell:ignore refback sayre slatkin
    +# cspell:ignore timegate timemap trackback webmention
    

    These lines could be wrapped more tightly.

  3. +++ b/core/misc/cspell/dictionary.txt
    @@ -47,7 +47,6 @@ anyall
    -archiver
    

    Not convinced we should remove this, "archiver" is a valid word.

  4. +++ b/core/misc/cspell/dictionary.txt
    @@ -1126,13 +1106,13 @@ phpdoc
    +phplint
    

    Where did this come from?

quietone’s picture

StatusFileSize
new2.51 KB
new8.43 KB

16.
1 and 2. fixed.
3. archiver restored to dictionary
4. I have no idea. removed.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

spokje’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

Doesn't apply on 9.4.x-dev any more

beatrizrodrigues’s picture

Assigned: Unassigned » beatrizrodrigues

I'll do the reroll

beatrizrodrigues’s picture

Assigned: beatrizrodrigues » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new8.4 KB

Here's the reroll.

spokje’s picture

Status: Needs review » Needs work

Thanks for the reroll.

Looks like all the additions to /core/misc/cspell/dictionary.txt in #21 are unneeded and probably removed in an already committed issue between #17 and now.

So basically, I think we can get rid off:

  1.   +++ b/core/misc/cspell/dictionary.txt
      @@ -49,9 +49,7 @@ asdf
      +asubject
      
  2.   +++ b/core/misc/cspell/dictionary.txt
      @@ -243,7 +239,8 @@ commontest
      +config's
      +configtranslation
      
  3.  +++ b/core/misc/cspell/dictionary.txt
      @@ -744,7 +730,7 @@ loremipsumloremipsum
      +lspeak
      
beatrizrodrigues’s picture

Status: Needs work » Needs review
StatusFileSize
new8.36 KB
new457 bytes

thanks @Spokje Here's a new patch that addresses your comment. And a interdiff too. Hope it fits.

spokje’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, RTBC for me now :)

catch’s picture

Status: Reviewed & tested by the community » Needs work

I'm not sure about this:

1. The .yml files get read by humans a lot more often than dictionary.txt, this adds a lot of noise to them.
2. #2979588: Deprecate Laminas\Feed reader and writer services will remove a lot of the words in core.services.yml anyway.
3. Why not have drupalci in the dictionary?

longwave’s picture

#25.1 Should we consider excluding e.g. core.services.yml from being spellchecked instead? Note that doing this has picked up a minor typo in a test (Configentity vs ConfigEntity) so I think leaving them all as dictionary words is not necessarily the right thing to do either.

Agree that #25.2 will eventually remove a lot of these exceptions anyway.

quietone’s picture

Issue summary: View changes
Status: Needs work » Postponed

Good points in #25 and #26.

Ignoring core.services.yml makes a lot of sense to me, it seems likely to always have words that will fail spelling.

Regarding Configentity, while it was found because of looking for words used once in yml files, it could easily be discovered by other means, say, doing words beginning with 'c'. I was searching for words used once to get quick wins to reduce the size of the dictionary.

How about just postponing this until #2979588: Deprecate Laminas\Feed reader and writer services.

longwave’s picture

Re: core.services.yml: the only English text is a handful of comments (less than 3% of the file) and deprecation messages - but any deprecation should also have an accompanying test which will still be spellchecked. Therefore if we can accept that the small number of comments will not be spellchecked I think it is worth it to avoid many false words that need ignoring one way or another.

quietone’s picture

Issue summary: View changes

Update the IS to show the issue this is postponed on.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Issue tags: +cspell error

Adding tag for the cspell spelling error issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.