Problem/Motivation

This will remove the services deprecated in #2979588: Deprecate Laminas\Feed reader and writer services

Proposed resolution

Do it

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 interdiff_8-11.txt3.07 KBravi.shankar
#11 3258435-11.patch42.66 KBravi.shankar
#8 3258435-8.patch39.59 KBravi.shankar
#5 3258435-5.patch42.62 KBalexpott
#2 3258435-2.patch10.07 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3258435-2.patch10.07 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

So one interesting question is do we want to continue accessing the container to check for feed.writer.* and feed.reader.* services - or should we deprecate that too and replace it with the ability to call \Laminas\Feed\Reader\StandaloneExtensionManager::add()

Not sure that affects this issue much but it might help us move the feed.bridge.reader and feed.bridge.writer services to aggregator. Amusingly we could deprecate the feed.bridge.writer service because absolutely nothing uses it. And we could deprecate the feed.bridge.reader in core and move it to aggregator. That would help encapsulate the dependency a bit better.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

Maybe we should wait to see which way we go on #2919215: Deprecate feed.bridge.writer so we can wait to see which way we go on that one.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
FileSize
3258435-5.patch42.62 KB

Rerolled and included the feed.bridge.reader and feed.bridge.writer services that were deprecated.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

One more step towards dropping Laminas Feed as a dependency.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll but looks great.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3258435-8.patch39.59 KB

Added reroll of patch #5.

Status: Needs review » Needs work

The last submitted patch, 8: 3258435-8.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

LegacyServiceTest was missed from the reroll, but it can be deleted entirely now.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3258435-11.patch42.66 KB
interdiff_8-11.txt3.07 KB

Deleted LegacyServiceTest file.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Thank you.

  • catch committed cfd1cf7 on 10.0.x 
    Issue #3258435 by ravi.shankar, alexpott, longwave: Remove deprecated...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed cfd1cf7 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.