\Drupal\Component\Utility\Bytes::toInt() - ensure $size is a number type

1. The round() returns float (or false).

 * @return float|false The rounded value
 */
function round ($val, $precision = 0, $mode = PHP_ROUND_HALF_UP) {}

2. It doesn't matter if we pass an integer (20) or a float (20.0) to round().

-    // Ensure size is a proper number type.
-    $size = strpos($size, '.') !== FALSE ? (float) $size : (int) $size;
+    // A number should be passed to the round() since PHP 8.
+    $size = (float) $size;

or much easier

     else {
-      return round($size);
+      // A number should be passed to the round() since PHP 8.
+      return round((float) $size);
     }
   }

In a light of php 7.4 https://wiki.php.net/rfc/numeric_literal_separator and https://wiki.php.net/rfc/string_to_number_comparison

This changes needs work

+++ b/core/tests/Drupal/Tests/Component/Utility/BytesTest.php
@@ -56,6 +56,8 @@ public function providerTestToInt() {
+      ['1.5', 2],
+      ['2.4', 2],

test-only passes

I disagree with change - PHP properly threads floats as strings (after preg_replace)

The code shows that PHP 8 throws notice in case of wrongly formatted numeric-string

/srv # php -v
PHP 8.0.0alpha3 (cli) (built: Jul 23 2020 19:54:36) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.0alpha3, Copyright (c), by Zend Technologies
/srv # php8 -r "var_dump(round('12.2'));"
float(12)
/srv # php8 -r "var_dump(round('12,2'));"
PHP Notice:  A non well formed numeric value encountered in Command line code on line 1

Notice: A non well formed numeric value encountered in Command line code on line 1
float(12)

but the later does not notice in PHP 7.4

/srv # php -v
PHP 7.4.8 (cli) (built: Jul 15 2020 15:47:18) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.8, Copyright (c), by Zend Technologies
/srv # php -r "var_dump(round('12,2'));"
float(12)

It means this cast just hides error, the same happening in #3156878-3: \Drupal\Component\Datetime\DateTimePlus should pass correct parameter types to checkdate()

I discovered an additional problem looking at https://3v4l.org/OUJaH bytes_to_int('12,2'); returnsfloat(122).

I created follow-up. See #3161729: Bytes::toNumber($size) will throw warning is $size failed to parse and #3161730: [META] Refactor \Drupal\Component\Utility\Bytes::toInt().

Committed ff72265 and pushed to 9.1.x. Thanks!

c/p to 9.0.x

Leaving open for discussion about backporting

C/p to 8.9.x - thanks

This patch should have probably included a fix for the line above the else:

return round($size * pow(self::KILOBYTE, stripos('bkmgtpezy', $unit[0]))); is returning the error: TypeError: Unsupported operand types: string * int in Drupal\Component\Utility\Bytes::toNumber()

apologies, this issue was for Bytes::toInt which is now deprecated. My issue is with the Bytes::toNumber function albeit it still applies.

@rondog469 mind opening a new issue with your report? Unlikely anything will happen on an issue that has been closed for 3 years.

@mondrake Yup I just did and I linked back to this one for reference purposes https://www.drupal.org/project/drupal/issues/3352728