Parameter $event of method Drupal\workspaces\EventSubscriber\WorkspaceRequestSubscriber::onKernelRequest() has
typehint with deprecated class Symfony\Component\HttpKernel\Event\GetResponseEvent:
since Symfony 4.3, use RequestEvent instead

src/EventSubscriber/WorkspaceRequestSubscriber.php

CommentFileSizeAuthor
#3 3113873-3.patch4.17 KBhimmatbhatia

Comments

himmatbhatia created an issue. See original summary.

himmatbhatia’s picture

himmatbhatia commented
Assigned: Unassigned » himmatbhatia
himmatbhatia’s picture

himmatbhatia commented
Status: Needs work » Needs review
StatusFileSize
new 3113873-3.patch4.17 KB

Removed the deprecated code. from core/workspaces module

himmatbhatia’s picture

himmatbhatia commented
Assigned: himmatbhatia » Unassigned
himmatbhatia’s picture

himmatbhatia commented
sanjayk’s picture

sanjayk commented
Assigned: Unassigned » sanjayk
sanjayk’s picture

sanjayk commented
Assigned: sanjayk » Unassigned

@himmatbhatia

I have test the above patch. It's successfully apply the patch and after apply patch everything working fine.

cilefen’s picture

cilefen commented
Title: Depricated code in the core/workspaces module » Deprecated code in the core/workspaces module
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think this is a duplicate of #3094398: Update Symfony response and request events to new classes which covers all modules.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Closed (duplicate)
Related issues: +#3094398: Update Symfony response and request events to new classes

I have confirmed what @longwave pointed out. This changes in this patch for WorkspaceRequestSubscriber* are covered by #3094398: Update Symfony response and request events to new classes. Added related issue and closing this.