Closed (fixed)
Project:
Drupal core
Version:
9.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Nov 2019 at 12:05 UTC
Updated:
20 May 2020 at 14:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottOne interesting question is should we leave the typehints alone for maximum SF4 compatibility?
Comment #3
mikelutzComment #4
klausiPatch does not apply anymore.
Comment #5
klausiComment #6
martin107 commentedI will sort out the reroll.
Comment #7
martin107 commentedreroll.
Comment #8
martin107 commentedFixed a problem common to many failures.
Comment #10
martin107 commentedActiveLinkResponseFilterTest now passes locally.
This is part of a larger thing, but it will be good to use symfony 5
Comment #11
martin107 commentedComment #12
thalles#10 applied with success!
Thanks @martin107!
Comment #13
andypostReroll after #3113876: The "Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent::getException()" method is deprecated since Symfony 4.4, use "getThrowable()" instead
Comment #14
klausiGetResponseEvent and FilterResponseEvent replacements look good.
Looks like we did not catch all TerminateEvent:
Comment #15
klausiSorry for the confusion, I should have checked for PostResponseEvent which was replaced by TerminateEvent.
That also looks good, thanks!
Comment #16
longwavePossible duplicates:
#3113873: Deprecated code in the core/workspaces module
#3113884: Remove usage of deprecated GetResponseEvent and FilterResponseEvent classes
#3114773: Parameter $event of method Drupal\workspaces\EventSubscriber\WorkspaceRequestSubscriber::onKernelController() has typehint with deprecated class
Comment #17
xjmComment #20
catchCommitted/pushed to 9.1.x and cherry-picked to 9.0.x, thanks!