Hello,

in the Seven theme my browser has sometimes performance problems to display the permissions form at admin/people/permissions because the form gets bigger and bigger due to ~100 modules. The modules are all needed :-/

Perhaps there is a way to improve permission display/handling

Here are my thoughts about:

  • display in a first step only the permission category (e.g. paragraph permission) as a collapsed container. if the user clicks on the container title, load the requested permissions dynamically via ajax
  • Make the form searchable and filterable. There the "module filter" module could be a role model
CommentFileSizeAuthor
#19 3108575_review.png59.3 KBhmendes
#18 interdiff_12-18.txt3.19 KBranjith_kumar_k_u
#18 3108575-18.patch4.03 KBranjith_kumar_k_u
#12 interdiff_11_12.txt816 bytesanmolgoyal74
#12 make_permissions_adm-3108575-12.patch4.05 KBanmolgoyal74
#11 interdiff_5_11.txt1.47 KBanmolgoyal74
#11 make_permissions_adm-3108575-11.patch4.12 KBanmolgoyal74
#9 3108575-after_patch_2.png24.46 KBabhijith s
#9 3108575-after_patch_1.png41.15 KBabhijith s
#5 make_permissions_adm-3108575-5.patch4.22 KBscott weston

Comments

dercheffe created an issue. See original summary.

dercheffe’s picture

dercheffe
he/him
Primary language German
Location Sersheim, Germany
commented
Issue summary: View changes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Improve permissions form in Claro » Improve permissions form
Component: Claro theme » user.module
Issue tags: +Usability

Great idea! We might have to make this in a broader scope than Claro because we will likely make changes to the page controller. Moving this to the user.module and tagging with usability.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Title: Improve permissions form » Make Permissions Administration page Searchable & Filterable (like Module Administration page)
scott weston’s picture

scott weston commented
Assigned: Unassigned » scott weston
StatusFileSize
new make_permissions_adm-3108575-5.patch4.22 KB

Adding a table filter similar to the Views list page, which allows for entering text and seeing matching rows.

To help with context, I kept the module names in place, so that a user will know the module which is providing the permission.

scott weston’s picture

scott weston commented
Assigned: scott weston » Unassigned
Status: Active » Needs review

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3108575-after_patch_1.png41.15 KB
new 3108575-after_patch_2.png24.46 KB

Patch #5 apllied cleanly on 9.2.x. The search bar is appeared in permissions section and the search functionality is working.But when I search something and scroll down the columns( excluding first one ) will be misaligned.Adding screenshots below.

After patch( search bar appeared):

after

After patch(columns misaligned):
after2

abhijith s’s picture

abhijith s commented
Status: Needs review » Needs work
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs work » Needs review
StatusFileSize
new make_permissions_adm-3108575-11.patch4.12 KB
new interdiff_5_11.txt1.47 KB

Fixed the custom command failed cases.

anmolgoyal74’s picture

anmolgoyal74 commented
StatusFileSize
new make_permissions_adm-3108575-12.patch4.05 KB
new interdiff_11_12.txt816 bytes

Fixed the remaining failures.

anmolgoyal74’s picture

anmolgoyal74 commented

Not sure why it is still getting field?

babusaheb.vikas’s picture

babusaheb.vikas commented

I have reviewed patch #12 and this is working fine for me.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented

Applied patch #12 in drupal-9.3.x-dev applied successfully
but filter is not working

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 3108575-18.patch4.03 KB
new interdiff_12-18.txt3.19 KB
hmendes’s picture

hmendes commented
Status: Needs review » Needs work
StatusFileSize
new 3108575_review.png59.3 KB

The filter worked for me but I didn't like the way the results were displayed.
If I search "Contact", for example, it will show the permissions but will also show the title of all permissions, and if i have a lot of modules installed it won't help that much as I will still have to scroll down to find that permission...

Isn't there a way to display on the permission i searched for and not all of them? Just like Module Administration page

Tested the patch from #18 in Drupal 9.4.x.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs work » Closed (duplicate)

There is an older issue for this topic here: #229193: Incremental filter for permissions page