Contextual module's js files read Press the esc key to exit., but it should be Press the Esc key to exit.. A patch is on the way.

CommentFileSizeAuthor
#10 3102129-after_patch.png43.01 KBabhijith s
#6 3102129-6.patch2.21 KBagrochal
#2 3102129-2.patch1.35 KBkartagis

Comments

Kartagis created an issue. See original summary.

kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented
Status: Active » Needs review
StatusFileSize
new 3102129-2.patch1.35 KB
rajeev_drupal’s picture

rajeev_drupal commented
Assigned: Unassigned » rajeev_drupal
rajeev_drupal’s picture

rajeev_drupal commented

Correct. It should be 'Esc' Patch looks correct.

rajeev_drupal’s picture

rajeev_drupal commented
Assigned: rajeev_drupal » Unassigned
agrochal’s picture

agrochal commented
StatusFileSize
new 3102129-6.patch2.21 KB

What about changing 'esc' and 'ESC' in comments to 'Esc'?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Yes, correcting the comments too is appropriate.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3102129-after_patch.png43.01 KB

Applied patch #6 and it works fine.The casing of "esc" is changed in the patch.

after

abhijith s’s picture

abhijith s commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Are we sure about "Esc" vs "esc" - at least on my current computer the key is labelled "esc". There are other examples of "esc key" and ckeditor help uses "press ESC". Are we sure there is a correct answer here?

Plus the .js file is not correctly compiled from the .es6.js see https://www.drupal.org/node/2815083 for how to do this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Also note that Drupal core atm is consistent in that all text shown to the user uses esc :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The key name is usually written Esc, Escape, or ESC, but I don't see any confusion in esc, given that some keyboards label it esc. (Truly, there are keyboards still using Esc). esc key is surely better than escape key.

I am not sure it's worth changing that. Are there users who get confused from press the esc key to exit?
I don't think it should be corrected on the basis that, since it's a key name, it should be written Esc. If that were the case, we should also write the Return/Enter key.

kartagis’s picture

kartagis
Primary language Turkish
Location Istanbul
commented

@kiamlaluno's comment makes sense. Should I close the issue?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@Kartagis I take alex's comments are saying the patch needs to be fixed/expanded. It needs to be fixed because it is changing just the .es6.js files, while the .js files should be compiled as described in https://www.drupal.org/node/2815083. It needs to be expanded as those aren't the only files were the key is called the esc key.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented

#2 patch applied successfully
after patch esc changed to Esc
Thanks for the patch

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Closed (won't fix)

I am not sure it's worth changing that. Are there users who get confused from press the esc key to exit?

Should I close the issue?

Yes, I think so

Reminded me of this classic

https://www.youtube.com/watch?v=SGzkUgTgpa4