Closed (outdated)
Project:
Tour
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Dec 2019 at 19:52 UTC
Updated:
1 May 2024 at 19:06 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
joachim namysloComment #3
joachim namysloComment #4
joachim namysloComment #5
joachim namysloHere is a live example from Varbase update 8.7 to 8.8
Comment #6
joachim namysloComment #7
mradcliffeI'm not sure where to start here, and though it was suggested to add the Novice tag I'm not sure what the actionable task is. Generally issues work best for novices when there is clear consensus on what to do.
I think at least adding the issue summary template and identify novice tasks for new contributors, then it might still be a Novice issue.
Comment #8
joachim namysloHopefully, someone will take a look at that before Drupal 9 comes out. Maybe it's just a regex-pattern to change. I don't know where the routine lives. as I said in the updated Issue template. In my opinion, this is not a novice thing. But I am glad that someone noticed and broght it up again.
Comment #9
joachim namysloComment #10
joachim namysloComment #11
joachim namysloOK it seems this is plugged in by useing a jquery lib and next isn't psrsed trough (t) will Update this as soon as I find the Code Block again.
Comment #12
joachim namysloOK it seems this is plugged in by useing a jquery lib and next isn't psrsed trough (t) will Update this as soon as I find the Code Block again.
Comment #13
joachim namysloCode in
lin 61 - 75 looks like
The file is tour.js and toures6.js so in js not t() is possible. Therefore the next in tour UI isn't translateable right now.
The text string is in core/assets/vendor/jquery-joyride/jquery.joyride-2.1.js
line 215
So how to get the next parsed trogh t()?
Edited the file and changed next to the german equivalent Weiter. just to see if the line above is the right one.
So If anyone able to provide a patch to tranlate the txt string although it comes from a js file that would help a lot.
Comment #14
joachim namysloComment #15
sokru commentedCould attached patch solve this issue?
Comment #16
baluertlComment #18
bmagalhaes commentedHello,
Just use the patch attached
Comment #19
psf_ commentedThe patch in #15 duplicate the string, and the patch in #18 is applied over an external library, I think is not the best practice.
Comment #20
joachim namysloLet's close this in favor of #2901517: Next Button Translation
Comment #21
joachim namysloComment #22
joachim namysloReopen This issue because it still exists in Drupal 9.1.5 So Maybe some one more tchnically versed, than me should check if core still uses joiride just like beforre or if there is a different approach for the tour functionality right now.
Comment #23
joachim namysloComment #24
anruetherBut isn't it indeed a dup of that issue? We don't need two issues for the same thing. Did you test the patch in the other issue? If it fixes the problem, please give feedback there.
Comment #28
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #29
quietone commentedThis should be in the tour.module component.
This extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
Comment #31
quietone commentedComment #32
smustgrave commentedThis appears to have been fixed in #3051766: Deprecate and replace jQuery Joyride (for tours)