Create a test trait for assertAnnounceContains and assertAnnounceNotContains

Believe this is still a valid request but will need to be updated for D10

Rerolled.

Also think this falls under unit testing more

Is this patch intended to replace all instances where #live-announce is used? If so there are some in these two methods masquerading as waitForText([text]) or $this->assertNotEmpty($assert_session->waitForText('[message]')) which break when they cannot be seen as I discovered in #2707291: Disable body-level scrolling when a dialog is open as a modal

\Drupal\Tests\media_library\FunctionalJavascript\MediaLibraryTestBase::switchToMediaLibraryGrid
\Drupal\Tests\media_library\FunctionalJavascript\MediaLibraryTestBase::switchToMediaLibraryTable
\Drupal\Tests\media_library\FunctionalJavascript\EntityReferenceWidgetTest::testWidget

Correct I believe the intention was to move those announce functions into a single trait.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

patch #15 no longer applied with
error: patch failed: core/modules/contextual/tests/src/FunctionalJavascript/EditModeTest.php:123
error: core/modules/contextual/tests/src/FunctionalJavascript/EditModeTest.php: patch does not apply
error: patch failed: core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php:114
error: core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php: patch does not apply

I found one super small nitpick

+++ b/core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php
@@ -131,9 +134,7 @@ public function testBlockFilter() {
     $announce_element = $page->find('css', '#drupal-live-announce');

This line can be removed I think? It is only used for the check later in the test.

Otherwise this change looks great and is rtbc imo.

I am currently working with @borisson on an internal Calibrate contribution day, I have incorporated his suggestion.

I had added all the changes to the interdiff, my apologies here is the correct file.

Looks like the file was not complete, combined #19 and the interdiff in #23.

There are some more tests that look like they could be converted to use the new trait?

core/modules/media_library/tests/src/FunctionalJavascript/WidgetUploadTest.php
core/modules/system/tests/src/FunctionalJavascript/ModuleFilterTest.php
core/modules/system/tests/src/FunctionalJavascript/ModuleUninstallFilterTest.php
core/tests/Drupal/FunctionalJavascriptTests/Ajax/CommandsTest.php
core/tests/Drupal/FunctionalJavascriptTests/Theme/ClaroViewsBulkOperationsTest.php

Searched for

->elementTextContains('css', '#drupal-live-announce'

and found 9 instances

Search for

$this->waitForElementTextContains('#drupal-live-announce'

found 2.

Guess those could be converted pretty easily here vs a follow up.

Discussed with @lauriii at Drupal Dev Days when committing #2707291: Disable body-level scrolling when a dialog is open as a modal.

We think this should go directly into WebAssert instead of a trait, because we already have a number of status message assertions in WebAssert and we want to encourage people to use this; discovery is harder if this is in a separate trait.