Problem/Motivation
While working on #3035392: Migrate vocabulary translations and taxonomy term references for Drupal 7 node translations it was discovered that the term reference for the vocabulary fixed field wasn't working. What it was doing was migrating the term reference used the last migrated translation to all the translations of that node. For example, node/1 had a term reference of 'X' and the Icelandic translation did not have a term reference. When that got migrated both node/1 and is/node/1 had a term reference of NULL.
After working with Gabor I finally saw the problem, it was the setting 'Users may translate this field' on admin/structure/types/manage/article/fields/node.article.vocab_fixed. When FALSE, we get the behavior described above and when TRUE we get the behavior we want.
This issue is to correct that problem. The original issue is #2979970: Migrate D7 vocabulary language settings which has excellent graphics by masipila in the IS. Highly recommend you take a look.
Proposed resolution
Change the vocab fixed language setting migration from:
D8 content type field settings for the term reference 'Users may translate this field': FALSE
To;
D8 content type field settings for the term reference 'Users may translate this field': TRUE
Remaining tasks
Patch
Review
Commit
Comment | File | Size | Author |
---|---|---|---|
#2 | 3080492-2.patch | 2.92 KB | quietone |
Comments
Comment #2
quietone CreditAttribution: quietone at Acro Commerce commentedAnd a patch.
Comment #3
quietone CreditAttribution: quietone at Acro Commerce commentedComment #4
quietone CreditAttribution: quietone at Acro Commerce commentedComment #5
quietone CreditAttribution: quietone at Acro Commerce commentedThis is a blocker to #3035392: Migrate vocabulary translations and taxonomy term references for Drupal 7 node translations
Comment #6
quietone CreditAttribution: quietone at Acro Commerce commentedComment #7
Gábor HojtsyLooks good as hinted above we debugged this together :) The field needs to be translatable, so fixed language terms can be assigned to only the respective translations while other translations would not get the same term.
This is blocking #3035392: Migrate vocabulary translations and taxonomy term references for Drupal 7 node translations so would be good to get in ASAP :)
Comment #8
Gábor HojtsyRetitle to be more accurate.
Comment #9
quietone CreditAttribution: quietone at Acro Commerce commentedWoohoo!
Comment #10
alexpottCommitted a086c94 and pushed to 8.8.x. Thanks!
Doing a test run against 8.7.x.
Comment #12
alexpottOkay it looks as though this patch doesn't apply to 8.7.x so if we want to backport the fix we're going to have to do some work. I'm going to close the issue as we've got this fixed in 8.8.x. If someone feels it is worth fixing in 8.7.x then we can re-open the issue.