Problem/Motivation

While working on #3035392: Migrate vocabulary translations and taxonomy term references for Drupal 7 node translations it was discovered that the term reference for the vocabulary fixed field wasn't working. What it was doing was migrating the term reference used the last migrated translation to all the translations of that node. For example, node/1 had a term reference of 'X' and the Icelandic translation did not have a term reference. When that got migrated both node/1 and is/node/1 had a term reference of NULL.

After working with Gabor I finally saw the problem, it was the setting 'Users may translate this field' on admin/structure/types/manage/article/fields/node.article.vocab_fixed. When FALSE, we get the behavior described above and when TRUE we get the behavior we want.

This issue is to correct that problem. The original issue is #2979970: Migrate D7 vocabulary language settings which has excellent graphics by masipila in the IS. Highly recommend you take a look.

Proposed resolution

Change the vocab fixed language setting migration from:
D8 content type field settings for the term reference 'Users may translate this field': FALSE

To;
D8 content type field settings for the term reference 'Users may translate this field': TRUE

Remaining tasks

Patch
Review
Commit

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone’s picture

Status: Active » Needs review
quietone’s picture

Title: Allow uses to translate fixed vocabulary term ref fields » Allow users to translate fixed vocabulary term ref fields
quietone’s picture

quietone’s picture

Issue tags: +blocker
Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Looks good as hinted above we debugged this together :) The field needs to be translatable, so fixed language terms can be assigned to only the respective translations while other translations would not get the same term.

This is blocking #3035392: Migrate vocabulary translations and taxonomy term references for Drupal 7 node translations so would be good to get in ASAP :)

Gábor Hojtsy’s picture

Title: Allow users to translate fixed vocabulary term ref fields » Migrate fixed vocabulary term reference fields as translatable to conform to data expectations when nodes get merged

Retitle to be more accurate.

quietone’s picture

Woohoo!

alexpott’s picture

Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed a086c94 and pushed to 8.8.x. Thanks!

Doing a test run against 8.7.x.

  • alexpott committed 18eae73 on 8.8.x
    Issue #3080492 by quietone, Gábor Hojtsy: Migrate fixed vocabulary term...
alexpott’s picture

Version: 8.7.x-dev » 8.8.x-dev
Status: Patch (to be ported) » Fixed

Okay it looks as though this patch doesn't apply to 8.7.x so if we want to backport the fix we're going to have to do some work. I'm going to close the issue as we've got this fixed in 8.8.x. If someone feels it is worth fixing in 8.7.x then we can re-open the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.