Allow synced Layout default Translations: translating labels and inline blocks

I rerolled it against 8.9, but I either messed up or I'm not seeing how this patch allows you to translate default layout builder config.

Alright, think something went wrong adding the patch to a running site (ran updb and it didn't fail), but reinstalling from scratch it works fine.

Now to see if I can add a button and the "don't show content preview" option.

Ok, translate button added and content preview toggle as well.

Also seems I uploaded a busted version of the patch before, so fixed that too. Changes are in interdiff.

Added config_translation module check

Working on it.

Rerolled most of the functionality of this long patch and adding here. Needs to work on it to make it completely reroll for 9.1.x. However, I think we can break the functionality if possible so that it can be helpful to review and do any changes for this functionality.

Thanks
Rajandro

Fixed the #21 error

FIxed phpcs violation of #24, adding interdiff from #21 to #25

PS: Four depreciation message needs to address lie as mentioned below:
+ @trigger_error('The entity_type.manager service must be passed to \Drupal\layout_builder\Element\LayoutBuilder::__construct(). It was added in Drupal 8.8.0 and will be required before Drupal 9.0.0.', E_USER_DEPRECATED);
+ @trigger_error('The plugin.manager.block service must be passed to \Drupal\layout_builder\InlineBlockEntityOperations::__construct(). It was added in Drupal 8.7.0 and will be required before Drupal 9.0.0.', E_USER_DEPRECATED);

Thanks

@Ted, Thank you.

re #26

Which patch were you working off for the reroll?

I have taken "3044993-12_plus_2946333-164-rerolled89x-19.patch" as a reference to reroll.

Thanks
Rajandro

And 3044993-12_plus_2946333-164-rerolled89x-19.patch is a full reroll, done using the proposed methods here: https://www.drupal.org/patch/reroll

Only hiccup was setContext method for DefaultsSectionStorage, which was added to core since the #12 patch, but I merged those (can be seen here: https://www.drupal.org/files/issues/2020-06-22/interdiff_16_18.txt). Didn't want to take any chances, so parent:: call is in between the two bits of code to match both sources.

Ok, seems there was a duplicate declaration of a property in the tests. Fixed that, again for 8.9.x. Sorry I'm not rerolling against 9.1 dev but we're still a ways off from moving to D9 and we need translations for LB now.

Reroll based on patch 202 in the other issue and this issue's 12 patch.

Re-rolled #30.

Hopefully fixes up some PHPCS and test failures

This could really use someone figuring out what parts of this patch are duplicated in #2946333: Allow synced Layout override Translations: translating labels and inline blocks and creating a 2nd patch that builds upon that work. The last time we had that split-up was back in #12. But I can't tell what since then is new or just attempts at fixing things up in a re-roll.

Leaving the re-roll tag on here, but only because we need to figure out what has changed in this issue since #12 and build a (hopefully) smaller patch that builds on top of the other.

NW for a re-roll.

@heddn I have checked after #12 there are no magor changes as per my understanding, few rerolls and PHPCS fixes are there, I am trying to understand, but no clue found, can you please help me out in this how to reroll this.

@here removing unused use statement.

Fixing CSPell issue.

Fixed failing test cases.

Here's #12 rerolled on top of the latest patch in the override issue, but not combined, so as a separate patch you can apply after applying the other issue's patch.

And then there's #12 + some minor updates in the same formfactor.

Hope this helps clear things up.

Forgot some pluses, added test changes from last rerolled patch.

Testing with Drupal 9.1.4. Installed both override issue #224 and this issue #48.
Generally works good, I could translate labels and they display correctly.

However, the "Translate layout" link URL is not always good.

First issue:
My installation uses a subdirectory in the path: http://localhost:8080/web/en/admin/bat/type-bundle/venue/edit/display/teaser
The prefix is duplicated: http://localhost:8080/web/web/en/admin/bat/type-bundle/venue/edit/display/teaser/translate

Second issue:
The default layout URL doesn't contain "/default" at the end: http://localhost:8080/web/en/admin/bat/type-bundle/venue/edit/display
So the translation link also misses that route param: http://localhost:8080/web/web/en/admin/bat/type-bundle/venue/edit/displa...
Should be: http://localhost:8080/web/en/admin/bat/type-bundle/venue/edit/display/default/translate

The problem is here, using the current URL as a base is not reliable:

+    $form['translate_layout'] = [
+      '#type' => 'link',
+      '#title' => $this->t('Translate layout'),
+      '#weight' => -9,
+      '#attributes' => ['class' => ['button']],
<strong>+      '#url' => Url::fromUserInput(
+        Url::fromRoute('<current>')->toString() . '/translate'
+      ),</strong>
+      '#access' => $is_enabled && $is_translatable,
+    ];
+

I've attached a quick fix patch that solves the problem for me, can be useful for someone else as well.
(Maybe it can give an idea for a permanent fix - but it's not intended to be the permanent solution itself.)

Tested with Drupal 9.2.5. Installed both override issue #238 and this issue #48.

Getting a 404 'page not found' when trying to translate a layout while the url looks fine: '/admin/structure/types/manage/[bundle]/display/[viewmode]/translate'

#49 Did not apply for me

I found another bug which is caused by #48.

The issue is:

I expect that for multilingual site when we clear cache in CLI, it should clear everything including field definitions cache BUT the patch from #48 adds layout_builder_config_translation_info() which is triggered after cache clear and it recreates cache of field definitions from scratch and might use different config override language than current language. If there is mismatch there will be a moment when you can see field labels in one language while your interface language is another language.

Here is improved patch which fixes the described above issue.

Updating the priority to Major as of the priority of the META issue. It would be expected to be able to translate all elements provided by core, but that's still not the case here. For default layouts, the labels and inline blocks still can't be translated.

Confirming this still needs work, the button "Translate layout" links to a non-existing page:
- /admin/structure/types/manage/aircraft/display/default/translate = 404 (Page not found)
- /admin/structure/types/manage/aircraft/display/translate = 403 (Access denied - with admin!)

The layout was created prior to applying the patch.

Created an issue fork from #52 (1:1) to proceed there. We should really get this fixed for 9.4, the current situation isn't appropriate for multilanguage sites with layout builder.

The patch from #52 has an issue when using domain-based language selection, an exception is thrown because Url::fromUserInput() gets an absolute URL. The attached patch fixes this.

Played around with the patch from #49 but wasn't successful, so reverting the MR to the previous state. My key problem is that I don't even understand which path / route is expected here. The current and the proposed solution both seem dirty?

What's the expected path for display layout translation? I can't get any working.

@Matthijs could you please provide an interdiff or fix it in the MR?

@Anybody: done!

MR is missing the newly added files from the patch. I'll fix this asap, seems I forgot the git add -.-

IMPORTANT:

The MR requires MR!1505 from #2946333: Allow synced Layout override Translations: translating labels and inline blocks! (https://git.drupalcode.org/project/drupal/-/merge_requests/1505#note_59580)
You have to use both combined to make it work!

MR should be fine so far, but I still get "Access denied" in the generated path:
admin/structure/types/manage/{NODE-TYPE}/display/translate
with user 1 (admin)

Any ideas?
This happens despite whatever I configure for translation settings on the node type. Even if translation is enabled, disabled, language set to a specific language, etc.

Some changes were missing in my previous patch (seems i forgot to "git add" as well), here the new one.

Fixed missing use statement.

@Matthijs: FYI you can always very simply create a patch file from Merge Request URL + ".diff" or click the "plain diff" link above:
https://git.drupalcode.org/project/drupal/-/merge_requests/1921.diff

So you don't have to create the patch file yourself with such risks.

Here is an improved d10 version of the patch based on #66 patch.

Tried to create an interdiff but it failed. Also if we use MR approach we need to switch the target branch for the fork and rebase it.

For the CC failure.

But can the IS be completed also, with the proposed solution

And if this requires #2946333: Allow synced Layout override Translations: translating labels and inline blocks then this should be postponed till that lands.

The last patch isn't compatible with the event dispatcher. The first argument must be an event object.
Updated a patch a bit.

Also, the code if ($section_storage->getTranslatedComponentConfiguration($component->getUuid())) { in LayoutEntityDisplayMapper::hasTranslatable() breaks the 'Translate layout' feature on the content view mode.

How to reproduce it:
- enable config_translation module
- enable layout builder for content type
- configure Layout Builder for some view mode
- try to make a translation of the layout

I see two issues here:
- The ConfigTranslationOverviewAccess::doCheckAccess() uses hasTranslatable() function and in this case $section_storage doesn't have language context
- even I'll add the language context the result still will be wrong, cuz getTranslatedComponentConfiguration() expects that config already contains the translation, it means that it doesn't work for 'add' translation action

I am trying to solve the layout builder translation issues for the first time and I am running into difficulties.

If I use patch 75 on its own I get the following error message:

Error: Interface "Drupal\layout_builder\TranslatableSectionStorageInterface" not found in /var/www/pwnhc/web/core/modules/layout_builder/src/DefaultsSectionStorageInterface.php on line 12 #0 /var/www/pwnhc/vendor/composer/ClassLoader.php(571): include()

If I apply the patch in this issue, https://www.drupal.org/project/drupal/issues/2946333 based off this merge request https://git.drupalcode.org/project/drupal/-/merge_requests/5956#note_259636 then that error goes away and I get a button called "Translate Layout".

The old merge request listed above (https://git.drupalcode.org/project/drupal/-/merge_requests/1504#note_194458) no longer applies to 10.2 - If this new patch would have fully worked I would replace it in the description.

I am having 2 issues with the 2 patches. Firstly I am using a path based URL and the path is duplicated in the Translate Layout button link so it goes to a page not found.

Details

• The manage display page is http://web2.local/pwnhc/en/admin/structure/types/manage/events/display
• The translate button points to http://web2.local/pwnhc/pwnhc/en/admin/structure/types/manage/events/dis...
• It should point to http://web2.local/pwnhc/en/admin/structure/types/manage/events/display/t...

Secondly with the corrected link I gotten 2 different outputs

1. An access denied error on the page. This was on an existing content type
2. On a new content type I go this: Error: Call to a member function get() on null in Drupal\layout_builder\Plugin\SectionStorage\DefaultsSectionStorage->getTranslatedComponentConfiguration() (line 481 of /var/www/pwnhc/web/core/modules/layout_builder/src/Plugin/SectionStorage/DefaultsSectionStorage.php).

If anyone can guide me to get better results I would appreciate it.

As documented in https://www.drupal.org/project/drupal/issues/3420019 patch #72 correctly applies to a Drupal 10.2.2 instance, but it breaks the site.

Rerolled for D10.3

Sorry, lost in where this is at. I swear (back in D9 at some point) i had tabs when in LB and one of those was to "Translate layout"; but now (D10.2.2.) NO tabs.

I have a vanilla D10.2.2 site with these patches:
- https://www.drupal.org/files/issues/2024-06-28/3044993-79.patch
- https://www.drupal.org/files/issues/2024-03-15/2946333-327_Revised_patch...

Additionally:
- Article type set to be translatable
- Basic block set to be translatable
- Article default view mode set to use LB (for all nodes)
- Add inline basic block using LB

There is no apparent UI to access translation of this. I have tried a couple urls as mentioned above:
en/admin/structure/types/manage/article/display/translate - access denied
en/admin/structure/types/manage/article/display/default/translate - throws:

Error: Call to undefined method Drupal\layout_builder\Plugin\SectionStorage\DefaultsSectionStorage::getTranslatedComponentConfiguration() in Drupal\layout_builder\ConfigTranslation\LayoutEntityDisplayMapper->hasTranslatable() (line 55 of E:\www\SSC\d10.0\web\core\modules\layout_builder\src\ConfigTranslation\LayoutEntityDisplayMapper.php).

Any hints?

switched to patch from #75 and now i see a Translate Layout button (at least now i know what the expected ui is); but it throws this error:

Error: Call to a member function get() on null in Drupal\layout_builder\Plugin\SectionStorage\DefaultsSectionStorage->getTranslatedComponentConfiguration() (line 481 of E:\www\SSC\d10.0\web\core\modules\layout_builder\src\Plugin\SectionStorage\DefaultsSectionStorage.php).

and now, magically, button gives Access Denied at: en/admin/structure/types/manage/article/display/translate

Rerolled patch for 11.x (using my rebase commit of https://www.drupal.org/project/drupal/issues/2946333 MR 5956)

Woops, missed an import in my patch

@l_vandamme The last patch doesn't apply to the latest Drupal 11.

Reroll attached of #85 applied agains Drupal 11.2.2 (with #356 from here also applied)

#87 is an incomplete patch, here is the right version