I'm preparing an installation profile under Drupal 8.6 which includes the ui_patterns family of modules. During installation, enumeration of layouts is triggered as part of yak shaving, and this results in an attempt to access the custom theme that isn't yet installed (because modules get installed before themes).

I've created a simple patch that attempts to install a theme before throwing the error and am submitting it for consideration / discussion.

CommentFileSizeAuthor
0001-Attempt-to-install-a-theme-before-throwing-an-except.patch1.17 KBnigelcunningham

Comments

NigelCunningham created an issue. See original summary.

cilefen’s picture

cilefen commented
Related issues: +#474684: Allow themes to declare dependencies on modules

What is the errror?

nigelcunningham’s picture

nigelcunningham commented

It throws the exception that comes just after the patch - "The theme %s does not exist.", and installation stops at that point (no further modules and no themes are installed). With the patch applied, I've successfully installed my profile.

cilefen’s picture

cilefen commented
Status: Active » Needs review
nigelcunningham’s picture

nigelcunningham commented
Issue summary: View changes

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Phil Wolstenholme’s picture

Phil Wolstenholme commented

We've been using this on a few sites for a while now and it seems to work fine 👍

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: -theme, -install profile +Needs issue summary update, +Bug Smash Initiative

Hi @NigelCunningham

Are you able to provide some more information with regards to the order of operations here?

For example, what in the module is relying on the pattern from the theme?

If the module does indeed rely on the pattern, is there a reason why the module itself can't define the pattern (you can put a .ui_patterns.yml file in modules too).

In the meantime I'm going to mark this issue as postponed needs more information.

If we don't receive additional information to help with the issue, it may be closed after three months.

Additionally, would it be possible to rewrite the issue summary using the standard template as there is some missing information.

Lee

nigelcunningham’s picture

nigelcunningham commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

I can't remember the context on this anymore, sorry; happy to close it.