The commit that was made on #2986901: Followup for #2666392: ConfigEntityTypeInterface::getPropertiesToExport no longer returns NULL, throws exception instead has caused a test failure / breakage in the Config Update Manager project -- see issue #2990516: Address test failures due presumably to changes in core.
The problem is that this commit changed the behavior of an API method ConfigEntityStorage::updateFromStorageRecord(). It no longer preserves the __core component of config when this method is called, and it used to.
We can work around this issue in our contrib module. However, I think that the Core patch should either be:
a) Reverted.
or
b) Documented in a change record.
Either one is probably OK, but I don't think making that change to the behavior of a public API function, without a change record is really OK. Thanks!
Comments
Comment #4
pameeela commented@jhodgdon, came across this while triaging old issues. Do you think the change notice is still required? If so maybe we should bump #2986901: Followup for #2666392: ConfigEntityTypeInterface::getPropertiesToExport no longer returns NULL, throws exception instead back to needs work?
Comment #5
pameeela commentedComment #6
jhodgdonAt this point I think we should just close this as Won't Fix.