#2666392: Unable to revert third party settings via config import added a new optional $id argument to ConfigEntityTypeInterface::getPropertiesToExport().
JSON API was not providing this $id argument (naturally) and some entities (specifically, configurable_language and responsive_image_style) caused our call to this method to throw an exception: https://www.drupal.org/pift-ci-job/1019447
We can easily add the new argument.
However, the documentation for the method still says that it can return NULL, but it appears that that is no longer a possibility. The docblock should be updated.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2986901-4.patch | 7.04 KB | alexpott |
| #2 | 2986901-2.patch | 1 KB | gabesullice |
Comments
Comment #2
gabesulliceComment #3
wim leersPointed to this issue from #2666392: #2666392-56: Unable to revert third party settings via config import.
Comment #4
alexpottReally nice find. Thanks for testing the alpha. I think we can do better here and not break BC but still have the important fix.
Comment #5
alexpottWith the patch in #4 there are no API changes to JSON API and other modules will continue to get NULL values if the annotation (and now the schema) is not defined.
Comment #6
gabesulliceThanks @alexpott! That is even better. Adjusting title to reflect what's being done here.
Comment #7
wim leers👏👌
Comment #8
wim leersGreen! I can't spot any problems, not even something to nitpick about.
Comment #9
catchCommitted/pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!
Comment #12
alexpott@tim.plunkett pointed out this is not in the correct component - moving.
Comment #14
jhodgdonAdding "Contributed project soft blocker" tag to this issue, because this commit broke the Config Update Manager contrib module. See #2993876: Change notice or revert needed for #2986901, which asks for this either to be reverted or a change record to be created, and #2990516: Address test failures due presumably to changes in core, where we are attempting to work around the problem.