The template suggestions for the More link template provided by the Views module are in the wrong order.

To reproduce:

  1. Activate the theme debug mode
  2. Create fake nodes
  3. Create a new view with a block display
  4. Add a more link
  5. Display the block somewhere
  6. Look at the suggestions in the page
CommentFileSizeAuthor
#19 2989945-19.patch3.36 KBranjith_kumar_k_u
#13 After--patch.jpg156.69 KBranjith_kumar_k_u
#13 Before--patch.jpg169.44 KBranjith_kumar_k_u
#11 2989945-11.patch3.4 KBraman.b
#11 2989945-11-test-only.patch2.56 KBraman.b
#6 core-views-suggestions-for-more-link-inversed-2989945-6.patch3.4 KBlevmyshkin
#3 Screenshot from 2019-01-08 22-37-44.png172.64 KBlevmyshkin
#3 Screenshot from 2019-01-08 22-34-31.png128.82 KBlevmyshkin
#2 core-views-suggestions-for-more-link-inversed-2989945-1.patch861 bytesb-prod

Comments

B-Prod created an issue. See original summary.

b-prod’s picture

b-prod commented
Status: Active » Needs review
StatusFileSize
new core-views-suggestions-for-more-link-inversed-2989945-1.patch861 bytes
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
StatusFileSize
new Screenshot from 2019-01-08 22-34-31.png128.82 KB
new Screenshot from 2019-01-08 22-37-44.png172.64 KB

I tested it, so it works fine with patch.

Before:

before

After:

after

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs review » Reviewed & tested by the community
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

As this is a bug, we need a test confirming the regression is resolved - thanks for your work!

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
StatusFileSize
new core-views-suggestions-for-more-link-inversed-2989945-6.patch3.4 KB

I added tests for template suggestions order.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs work » Needs review

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

raman.b’s picture

raman.b commented
Version: 8.9.x-dev » 9.2.x-dev
Issue tags: -Needs tests
raman.b’s picture

raman.b commented
StatusFileSize
new 2989945-11-test-only.patch2.56 KB
new 2989945-11.patch3.4 KB

Not sure why #6 is failing. Re-uploading #6 along with a test only patch

The last submitted patch, 11: 2989945-11-test-only.patch, failed testing. View results

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new Before--patch.jpg169.44 KB
new After--patch.jpg156.69 KB

The last patch works fine for me
Before patch
before patch.

After patch
after patch

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented

The issue still exists in 10.1

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 2989945-19.patch3.36 KB

Rerolled #11 for 10.1

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Closed (duplicate)
Issue tags: +Bug Smash Initiative
Related issues: +#3188122: Views more link container theme suggestions are in the wrong order

#3188122: Views more link container theme suggestions are in the wrong order

This issue is a duplicate, I'll transfer credit over there