In dblog module of drupal core db_select, db_query and db_query_range use is deprecated and instead it should be used with :
\Drupal::database()->select()
\Drupal::database()->query()
\Drupal::database()->queryRange()

CommentFileSizeAuthor
#12 interdiff-2955182-10-12.txt560 bytesyogeshmpawar
#12 2955182-12.patch10.56 KByogeshmpawar
#10 2955182-10.patch10.57 KByogeshmpawar
#6 deprecated-removed-2955182-6.patch13.94 KBmahaveer003
#2 deprecated-removed-2955182-2.patch13.92 KBmahaveer003

Comments

mahaveer003 created an issue. See original summary.

mahaveer003’s picture

mahaveer003 commented
Status: Active » Needs review
StatusFileSize
new deprecated-removed-2955182-2.patch13.92 KB

I have added the patch with removed all deprecated db_select, db_query and db_query_range please review.

mahaveer003’s picture

mahaveer003 commented
Assigned: mahaveer003 » Unassigned

Status: Needs review » Needs work

The last submitted patch, 2: deprecated-removed-2955182-2.patch, failed testing. View results

dravenk’s picture

dravenk
He/Him
Primary language English
commented 
+++ b/core/modules/dblog/tests/src/Kernel/DbLogControllerTest.php
@@ -17,6 +17,9 @@ class DbLogControllerTest extends KernelTestBase {
+  /**
+   *
+   */

These lines of blank comments are not described.

mahaveer003’s picture

mahaveer003 commented
Status: Needs work » Needs review
StatusFileSize
new deprecated-removed-2955182-6.patch13.94 KB

I have updated the patch

Status: Needs review » Needs work

The last submitted patch, 6: deprecated-removed-2955182-6.patch, failed testing. View results

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Component: database system » dblog.module

Thanks for working on this.

Please do not include all the fixes for coding standards here. This makes harder to review and can make other dblog patches hard to appy.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2955182-10.patch10.57 KB

As per suggestion in #8 by @dagmar, created new patch which removes all db_select() and db_query() deprecated from Dblog module.

Status: Needs review » Needs work

The last submitted patch, 10: 2955182-10.patch, failed testing. View results

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Needs review
StatusFileSize
new 2955182-12.patch10.56 KB
new interdiff-2955182-10-12.txt560 bytes

PHPLint error resolved & added updated patch with an interdiff.

Status: Needs review » Needs work

The last submitted patch, 12: 2955182-12.patch, failed testing. View results

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs work » Closed (duplicate)

Sorry for wasting your time, but I did some research and according to #2848161: [meta] Replace calls to deprecated db_*() wrappers

And db_query_range is used by test and should be replaced with a similar issue in all the modules.