Problem/Motivation

Follow up to #2926483: Add API methods for determining whether an entity object is the latest (translation-affecting) revision. Currently it's tricky to reliably know how many times an entity was loaded from storage in a test environment.

Proposed resolution

Implement a test entity storage class for this, which can be used in tests. \Drupal\entity_test\EntityTestNoLoadStorage is already doing something similar, it's a test storage implementation which adds some utility during testing.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 2933930-11.patch4.07 KBsam152
#6 2933930-6.patch4.07 KBsam152
#6 2933930-6_FAILING.patch4.84 KBsam152
#2 2933930-2.patch4.16 KBsam152
#2 2933930-2_FAILING.patch4.93 KBsam152

Comments

Sam152 created an issue. See original summary.

sam152’s picture

sam152 commented
StatusFileSize
new 2933930-2_FAILING.patch4.93 KB
new 2933930-2.patch4.16 KB

Applies on top of the blocker. Leaving as "Active" until that gets in.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review

Blocker gone :)

The last submitted patch, 2: 2933930-2_FAILING.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 2: 2933930-2.patch, failed testing. View results

sam152’s picture

sam152 commented
Status: Needs work » Fixed
StatusFileSize
new 2933930-6_FAILING.patch4.84 KB
new 2933930-6.patch4.07 KB

Fixing patch files.

sam152’s picture

sam152 commented
Status: Fixed » Needs review

The last submitted patch, 6: 2933930-6_FAILING.patch, failed testing. View results

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work

This makes a lot of sense, I like that this has an implementation in the test. This patch no longer applies.

sam152’s picture

sam152 commented
StatusFileSize
new 2933930-11.patch4.07 KB
sam152’s picture

sam152 commented
Status: Needs work » Needs review

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joachim’s picture

joachim commented
Status: Needs review » Needs work

Nitpicks:

  1. +++ b/core/modules/system/tests/modules/entity_test/src/EntityTestProfilerStorage.php
@@ -0,0 +1,45 @@
+   * The number of times a call resulted in an entity being loaded from storage.

    Should be a complete sentence.

    Something like: "Returns the number of times entities were loaded from storage."

  2. +++ b/core/modules/system/tests/modules/entity_test/src/EntityTestProfilerStorage.php
@@ -0,0 +1,45 @@
+   *   The number or entity loads from storage.

    The number *of*

Also the wording of the docs in general don't make it clear whether this is counting:

- the number of loads of a particular entity
- the number of entities that are loaded, as in, if I make a single load call for entities A and B, that's a count of 2
- the number of times entities are requested from storage (which is what it actually is).

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.