Problem/Motivation

I discovered that some classes have private member variables prefixed with single leading underscore character, which was standard in pre-visibility era. This is relic of the past and can be removed now.

Proposed resolution

Remove leading underscore from all private member variables.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 leading_underscore-2921676-2.patch35.07 KBzaporylie

Comments

zaporylie created an issue. See original summary.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Component: other » language system
Status: Active » Needs review
Parent issue: » #1637662: Clean up the Gettext PO parser
StatusFileSize
new leading_underscore-2921676-2.patch35.07 KB

After some digging I discovered that the only occurrences of private member variables with leading underscore character are located in Gettext component, so adding reference to #1637662: Clean up the Gettext PO parser and changing component on the issue.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Status: Needs review » Closed (duplicate)
Related issues: +#2935190: Fix variable names in Gettext component.

@zaporylie, thanks for the patch!

This was fixed in #2935190: Fix variable names in Gettext component. in March 2018. so I am closing as duplicate.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented

Glad it's been fixed, even if elsewhere.