Fix variable names in Gettext component.

I've checked the patch. The only things that are being changed are the properties. The initial underscore ('_') is being removed and the scope is being increased from private to protected.

After searching the codebase for rouge underscores I found the following:

core/lib/Drupal/Component/Gettext> grep -nr '$_' *
PoItem.php:32:   * @see $_plural
PoItem.php:54:   * @see $_plural
core/lib/Drupal/Component/Gettext> grep -nr '\->_' *
core/lib/Drupal/Component/Gettext>

This means that there are some instances in the comments that should be changed to match the updated code.

Setting back to Needs work for now. I've added the 'Novice' tag for updating the comments.

Made the changes as per #4 in PoItem.php file. Now the varibales are without underscore.

[ Asia ]

[ India ]

1. [ Bangalore ] - [ January 27 ] - Details

Looks good to me

The patch from Sutharsan affects a lot more files in this component. Is that not needed anymore? As per the issue scope this would cover the whole component no?

please review,
I took the patch from #2
and replaced the protected properties with private

+++ b/core/lib/Drupal/Component/Gettext/PoStreamReader.php
@@ -577,7 +577,7 @@ public function parseQuoted($string) {
-  private function shortenComments($comment) {
+  protected function shortenComments($comment) {

The patch looks good, but we should not change the visibility of this method.

Sry, the guy next to me is distracting me with his ICQ-Login attemps.

I still do not see #4 addressed:

/core/lib/Drupal/Component/Gettext (8.6.x)$ grep -nr '$_' *
PoItem.php:32:   * @see $_plural
PoItem.php:54:   * @see $_plural

Setting back to Needs work.

1. +++ b/core/lib/Drupal/Component/Gettext/PoItem.php
   @@ -31,21 +31,21 @@ class PoItem {
       * @see $_plural
   

   Remove `_` from variable name.

2. +++ b/core/lib/Drupal/Component/Gettext/PoItem.php
   @@ -53,7 +53,7 @@ class PoItem {
       * @see $_plural
   

   Remove `_` from variable name.

Fixed the #4 issue, please review.

This now looks good, results:

core/lib/Drupal/Component/Gettext (8.6.x)$ grep -nr '$_' *
core/lib/Drupal/Component/Gettext (8.6.x)$ grep -nr '\->_' *

thanks

1. +++ b/core/lib/Drupal/Component/Gettext/PoMemoryWriter.php
   @@ -12,13 +12,13 @@ class PoMemoryWriter implements PoWriterInterface {
   +  private $items;
   

   Why not protected?

2. +++ b/core/lib/Drupal/Component/Gettext/PoStreamReader.php
   @@ -577,7 +577,7 @@ public function parseQuoted($string) {
   -  private function shortenComments($comment) {
   +  protected function shortenComments($comment) {
   

   I'm not sure we should be changing function scope.

3. +++ b/core/lib/Drupal/Component/Gettext/PoStreamWriter.php
   @@ -12,21 +12,28 @@ class PoStreamWriter implements PoWriterInterface, PoStreamInterface {
   +  protected $langcode;
   

   This used to be dynamically declared right? So it was public. My first thought was that tt should stay public but with an @todo to make protected in D9. But actually it was prefixed by an underscore so it was meant to be private so I think this is okay.

Did changes as per #22, please review it :)

1. +++ b/core/lib/Drupal/Component/Gettext/PoStreamReader.php
   @@ -273,24 +273,24 @@ private function readLine() {
   +          return NULL;
   

   The change from return; to return NULL is out-of-scope.

2. +++ b/core/lib/Drupal/Component/Gettext/PoStreamWriter.php
   @@ -104,7 +111,7 @@ public function close() {
   -    $result = fwrite($this->_fd, $data);
   +    $result = fputs($this->fd, $data);
   

   Why change fwrite to fputs? fputs is an alias of fwrite but I didn't know one was preferred over the other. I think this is an out-of-scope change.

@alexpott, Thanks for the review, did changes as per #26.Providing interdiff of patch #24 and #28.

I think we should postpone this on #2935193: Fix broken exceptions in Gettext component - since that is a bugfix that should be backported to 8.5.x

Reroll, no interdiff.

Patch did not attach, trying again.

Adding review credit.

Committed d9f9378 and pushed to 8.6.x. Thanks!