Problem/Motivation

Discovered by @Bojhan in #2830584: Use modals for creating, updating, and deleting workflows, with a new DialogFormTrait:

What about just saying "Transition label" and "State label" then you dont need the description.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 2902247-11.patch2.7 KBdave.mikolaj
#7 2902247-7.patch2.7 KBsam152

Comments

Sam152 created an issue. See original summary.

sam152’s picture

sam152 commented
Issue summary: View changes
sam152’s picture

sam152 commented
Issue summary: View changes
sam152’s picture

sam152 commented
Issue summary: View changes
sam152’s picture

sam152 commented
Title: Make #labels of the "label" field in the Workflow(Transition|State)(Add|Edit)Form clearer and remove the description. » Make #title of the "label" fields in the Workflow(Transition|State)(Add|Edit)Form clearer and remove the description.
Bojhan’s picture

Bojhan commented
Issue tags: +Usability

I love removing unnecessary descriptions, lets do it!

sam152’s picture

sam152 commented
Status: Active » Needs review
StatusFileSize
new 2902247-7.patch2.7 KB
manuel garcia’s picture

manuel garcia commented

+1 from me, patch looks good, this is the only thing I would change =)

+++ b/core/modules/workflows/src/Form/WorkflowStateAddForm.php
@@ -60,10 +60,9 @@ public function form(array $form, FormStateInterface $form_state) {
+      '#title' => $this->t('State Label'),

+++ b/core/modules/workflows/src/Form/WorkflowStateEditForm.php
@@ -77,10 +77,9 @@ public function form(array $form, FormStateInterface $form_state) {
+      '#title' => $this->t('State Label'),

+++ b/core/modules/workflows/src/Form/WorkflowTransitionAddForm.php
@@ -61,10 +61,9 @@ public function form(array $form, FormStateInterface $form_state) {
+      '#title' => $this->t('Transition Label'),

+++ b/core/modules/workflows/src/Form/WorkflowTransitionEditForm.php
@@ -78,10 +78,9 @@ public function form(array $form, FormStateInterface $form_state) {
+      '#title' => $this->t('Transition Label'),

I think the L on the label should not be capitalised, should be 'State label', etc.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

@Manuel Garcia is correct; they should be sentence-case rather than title-case. Thanks!

sam152’s picture

sam152 commented
Issue tags: +Novice
dave.mikolaj’s picture

dave.mikolaj commented
StatusFileSize
new 2902247-11.patch2.7 KB

Changing to sentence-case.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
sam152’s picture

sam152 commented
Status: Needs review » Reviewed & tested by the community

Looks great @dave.mikolaj! Thanks.

manuel garcia’s picture

manuel garcia commented

+1 to RTBC

  • Gábor Hojtsy committed 7d63b2a on 8.5.x 
    Issue #2902247 by Sam152, dave.mikolaj, xjm, Bojhan: Make #title of the...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Looks like a nice straighforward improvement, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.