Move easyrdf/easyrdf to require-dev

easyrdf seems to be used as a reference implementation for RDF generated by Drupal in tests only.

So yes, we should move it to require-dev.

Unfortunately, running a test won't tell us whether we're right about this, but searching the codebase for 'easyrdf' seems to show that it's only being used in tests.

This needs a reroll, but this is right, this is only used in tests.

Even so, we don't know who may be using it.

Re-rolled patch in #5 for 8.6.x

@prithvi1972: When you upload a patch, it's good to set the issue status to 'Needs review,' so that the testbot CI system can test the patch.

Added change record: https://www.drupal.org/node/2955931

I'd RTBC but I wrote the patch being rerolled. :-)

I am at Drupalcon Nashville 2018 mentor sprint. Going to review this.

Applied the patch. The easyrdf line has moved as-is from require to require-dev in core/composer.json. The easyrdf segment in composer.lock appears to have moved, and the diff shows that as this massive section of green and red.. not sure if that matters. Doesn't seem like it would, but I could be wrong (composer is scurry). Marking this as RTBC with that caveat.

Giving @Jaesin credit for finding and opening this issue.
Giving @cilefen credit for requesting the change record.
Given @runeasgar credit for a through rtbc which outlines all the steps taken.

I was going to commit this and then I remembered that the tarball is packaged without dev dependencies. Therefore is possible a contrib or custom module is using easrdf without declaring a dependency or even being a composer acknowledging extension. That gives me pause. I think we need further release manager discussion.

Indeed. I don’t remember a case like this one. It could WSOD sites. We should postpone this to D9 because of BC and there being no pain felt by its presence.

Indeed. I don’t remember a case like this one. It could WSOD sites. We should postpone this to D9 because of BC and there being no pain felt by its presence.

I'm not sure about this, without deprecating this first, we're not allowed to remove this in D9 either. Is there a simple way to deprecate this so we can remove this in a later release?

Removing the novice tag, because this question makes it a bit more complicated than what a novice issue is supposed to be.

Those are valid points.

Rerolled on top of 9.0.x

Change record exists. Yay.

This will affect existing contrib modules - see http://codcontrib.hank.vps-private.net/search?text=EasyRDF&filename=

Looks great as a 9.0.x-only change and the release note and change record are straightforward and done.

Rerolled.

The reroll looks great. Thank you @shubham.prakash

Ah rerolling composer changes is tricky... it's normally best to recreate the patch entirely.

Here it is.

The way to do it is to:

• Remove easyrdf from core/composer.json
• Run composer require --dev easyrdf/easyrdf "^0.9"

Thanks for the information, will do that next time.

#3090017: Isolate test dependency on easyrdf/easyrdf to a single trait should remove this dependency altogether, but in the meantime this is a good change. (edit: and since I'd last looked, easyrdf had has added PHP 7.4 support so we probably in fact do not need to remove it).

Committed b11df2c and pushed to 9.0.x. Thanks!

I've published the CR and added the release notes tag.