Problem/Motivation

"easyrdf/easyrdf": "0.9.*" is a required library but it only looks to be used in tests. Shouldn't it go under require-dev.

Proposed resolution

Move the dependency to the correct location

Remaining tasks

User interface changes

None

API changes

Contrib / custom modules using EasyRDF need to add the dependency to their composer.json

Contrib modules will need to be updated for this change - http://codcontrib.hank.vps-private.net/search?text=EasyRDF&filename=

Data model changes

Release notes snippet

The package easyrdf/easyrdf is no longer a runtime dependency of Drupal and will not be included in tagged releases. Contributed or custom modules using EasyRDF need to add the dependency to their composer.json.

CommentFileSizeAuthor
#31 2901363-2-31.patch8.79 KBalexpott
#28 2901363-28.patch7.98 KBshubham.prakash
#26 2901363-26.patch8.32 KBalexpott
#22 2901363-22.patch6.58 KBalexpott
#9 2901363_9.patch5.52 KBprithvi1972
#5 2901363_5.patch5.5 KBMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jaesin created an issue. See original summary.

Jaesin’s picture

Jaesin CreditAttribution: Jaesin at Chapter Three commented
Component: other » rdf.module
cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented
Issue tags: +Composer
Jaesin’s picture

Jaesin CreditAttribution: Jaesin at Chapter Three commented
Issue tags: +beginner, +this-is-easy, +sprint
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Title: "easyrdf/easyrdf": "0.9.*" looks like it is only used in tests. » Move easyrdf/easyrdf to require-dev
Status: Active » Needs review
FileSize
2901363_5.patch5.5 KB

easyrdf seems to be used as a reference implementation for RDF generated by Drupal in tests only.

So yes, we should move it to require-dev.

Unfortunately, running a test won't tell us whether we're right about this, but searching the codebase for 'easyrdf' seems to show that it's only being used in tests.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Status: Needs review » Needs work
Issue tags: -beginner, -this-is-easy, -sprint +Novice, +Needs reroll

This needs a reroll, but this is right, this is only used in tests.

cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented
Version: 8.5.x-dev » 8.6.x-dev
Issue tags: +Needs change record

Even so, we don't know who may be using it.

prithvi1972’s picture

prithvi1972 CreditAttribution: prithvi1972 commented
FileSize
2901363_9.patch5.52 KB

Re-rolled patch in #5 for 8.6.x

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs reroll, -Needs change record

@prithvi1972: When you upload a patch, it's good to set the issue status to 'Needs review,' so that the testbot CI system can test the patch.

Added change record: https://www.drupal.org/node/2955931

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented

I'd RTBC but I wrote the patch being rerolled. :-)

runeasgar’s picture

runeasgar CreditAttribution: runeasgar as a volunteer commented

I am at Drupalcon Nashville 2018 mentor sprint. Going to review this.

runeasgar’s picture

runeasgar CreditAttribution: runeasgar as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Applied the patch. The easyrdf line has moved as-is from require to require-dev in core/composer.json. The easyrdf segment in composer.lock appears to have moved, and the diff shows that as this massive section of green and red.. not sure if that matters. Doesn't seem like it would, but I could be wrong (composer is scurry). Marking this as RTBC with that caveat.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented

Giving @Jaesin credit for finding and opening this issue.
Giving @cilefen credit for requesting the change record.
Given @runeasgar credit for a through rtbc which outlines all the steps taken.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs release manager review

I was going to commit this and then I remembered that the tarball is packaged without dev dependencies. Therefore is possible a contrib or custom module is using easrdf without declaring a dependency or even being a composer acknowledging extension. That gives me pause. I think we need further release manager discussion.

cilefen’s picture

cilefen CreditAttribution: cilefen as a volunteer commented

Indeed. I don’t remember a case like this one. It could WSOD sites. We should postpone this to D9 because of BC and there being no pain felt by its presence.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and commented
Issue tags: -Novice

Indeed. I don’t remember a case like this one. It could WSOD sites. We should postpone this to D9 because of BC and there being no pain felt by its presence.

I'm not sure about this, without deprecating this first, we're not allowed to remove this in D9 either. Is there a simple way to deprecate this so we can remove this in a later release?

Removing the novice tag, because this question makes it a bit more complicated than what a novice issue is supposed to be.

cilefen’s picture

cilefen CreditAttribution: cilefen at Institute for Advanced Study commented
Related issues: +#2957239: [policy, no patch] How to deprecate unused dependencies

Those are valid points.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Version: 8.9.x-dev » 9.0.x-dev
Issue summary: View changes
FileSize
2901363-22.patch6.58 KB

Rerolled on top of 9.0.x

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Issue summary: View changes

Change record exists. Yay.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Issue summary: View changes

This will affect existing contrib modules - see http://codcontrib.hank.vps-private.net/search?text=EasyRDF&filename=

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs release manager review

Looks great as a 9.0.x-only change and the release note and change record are straightforward and done.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
FileSize
2901363-26.patch8.32 KB

Rerolled.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
shubham.prakash’s picture

shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
2901363-28.patch7.98 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

The reroll looks great. Thank you @shubham.prakash

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 28: 2901363-28.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Status: Needs work » Reviewed & tested by the community
FileSize
2901363-2-31.patch8.79 KB

Ah rerolling composer changes is tricky... it's normally best to recreate the patch entirely.

Here it is.

The way to do it is to:

  • Remove easyrdf from core/composer.json
  • Run composer require --dev easyrdf/easyrdf "^0.9"
shubham.prakash’s picture

shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commented

Thanks for the information, will do that next time.

  • catch committed b11df2c on 9.0.x 
    Issue #2901363 by alexpott, Mile23, shubham.prakash, prithvi1972, Jaesin...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

#3090017: Isolate test dependency on easyrdf/easyrdf to a single trait should remove this dependency altogether, but in the meantime this is a good change. (edit: and since I'd last looked, easyrdf had has added PHP 7.4 support so we probably in fact do not need to remove it).

Committed b11df2c and pushed to 9.0.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Acro Commerce, Thunder commented
Issue tags: +9.0.0 release notes

I've published the CR and added the release notes tag.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes