Edit the date range error messages

Thanks. I think I like that error message better. Once you fix the fail, can you post an after screenshot to the IS? It will help with final review.

+++ b/core/modules/datetime_range/src/Plugin/Field/FieldWidget/DateRangeWidgetBase.php
@@ -136,7 +136,7 @@ public function validateStartEnd(array &$element, FormStateInterface $form_state
-          $form_state->setError($element, $this->t('The @title end date cannot be before the start date', ['@title' => $element['#title']]));
+          $form_state->setError($element, $this->t('The end of <em>@title</em> cannot be before its start.', ['@title' => $element['#title']]));

Most of core uses %title as the placeholder in error messafes, which will add the <em> element. That will also make it easier to translate.

And just as a general note, even though this is a bug, the string change means it can't go against 8.3.x (since this is still an experimental, a committer may decide otherwise).

#12, for the purpose of the test, I would be OK using @title. The main thing we are testing is the actual test and the error message.

See the comment on https://www.drupal.org/node/2863444#comment-12174307. I'm wondering if we need to split out the error messages to handle the case of same date, but end time < start time.

I'm good with this, but think a UX signoff is best here.

UX reviewer, is current message good or do we need to be more granular about the date/time portions in the error message? The current screenshots show date-only field, but this field can also capture date+time as two separate inputs.

Will try to post before/after screenshots of date+time tonight.

I am updating the issue description. The original had only one screenshot, which is now out of date. The description did not mention that the screenshot was made with the inline_form_errors module enabled. I am attaching before and after screenshots with and without that module.

Usability review

We discussed this issue at #3176758: Drupal Usability Meeting 2020-10-20.

We agree that the text change is a step in the right direction. While testing the patch, we noticed a few more things that should be improved:

1. When the Inline Form Errors module is enabled, the same message appears three times. Once is enough. The problem is deciding which one to keep.
2. When the Inline Form Errors module is enabled, we do not need the field label in the message. It could be simply "The End date cannot be before the Start date" (using the labels of the subfields) or "The end cannot be before the start."

We should not try to Fix Everything as part of this issue, but before this issue is fixed we should either create new issues or find existing ones. Either way, add them as related issues here. (If there is an easy way to do (2), then that could be added to this issue.) As far as testing and code review are concerned, this issue is RTBC, but I am setting the status to NW for the related issues.

I agree with @benjifisher in #33, this is a small patch which improves existing messaging, once follow-ups are created/found I'm happy with this being RTBC.

Thanks,
-Aaron

In sometimes the error messages are appear duplicate
This patch solve this issue, show error message only in end date field

In sometimes the error messages are appear duplicate
This patch solve this issue, show error message only in end date field