The ESLint config uses '2' for errors, '1' for warnings, and '0' to turn off a rule. Instead of numbers, we can use the more readable 'error' for errors, 'warn' for warnings, and 'off' to turn off a rule.

CommentFileSizeAuthor
#7 2877441-7.patch6.22 KBjofitz
#2 more-readable-eslint-config-2877441-2.patch6.22 KBfafnirical
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fafnirical created an issue. See original summary.

fafnirical’s picture

fafnirical
he/him
CreditAttribution: fafnirical at Forum One commented
Status: Active » Needs review
FileSize
more-readable-eslint-config-2877441-2.patch6.22 KB
fafnirical’s picture

fafnirical
he/him
CreditAttribution: fafnirical at Forum One commented
Assigned: fafnirical » Unassigned

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Issue tags: +Needs reroll

I agree that this is a good idea. The patch needs a reroll though.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Issue tags: -Needs reroll
FileSize
2877441-7.patch6.22 KB

Re-rolled.

marxjohnson’s picture

marxjohnson CreditAttribution: marxjohnson as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I've reviewed this and both files look good. I was momentarily confused as to why "max-nested-callbacks": ["warn", 3], still had a 3 instead of a word, but on closer inspection that's the number of nested callbacks allowed, and not another eslint reporting level.
I also ran eslint on a file before and after the patch, the output was the same in both cases.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
CreditAttribution: justafish as a volunteer and at Lullabot commented

Also reviewed - looks good. Great idea 👍

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Crediting @marxjohnson for an rtbc review which details all the steps taken and their thoughts whilst reviewing the patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 99f215b and pushed to 8.6.x. Thanks!

  • alexpott committed 99f215b on 8.6.x 
    Issue #2877441 by fafnirical, Jo Fitzgerald, marxjohnson: Improve...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.