Block layout action removes instance, but contextual link deletes all instances.

Needs a patch.

IMO those were relevant

As this issue has a "Novice" tag, so can you be a little more descriptive of where this change needs to be made.
I am a begginer and really wants to contribute to Drupal.

Patch passed.

Applied the patch in #11 . Worked cleanly for me. Please see the screens.

I'm looking to test this but I am not sure exactly which URL this is in Drupal as I can't reproduce the screenshots attached. Thanks

Thanks tkleary. I followed the steps in #19 and it passed testing.
Screen Shot 2017-01-10 at 20.43.12.png

After we click on the remove link the next page still shows delete.

Can confirm patch #11 works against core 8.3.x but the next page does still say delete (#21)

@tkoleary can you help me solve this? I am new here.

Changed contextual link and button on following page.

@tim.clifford the button on the next page also says delete!

As utkarsh_malviya points out, the form submit button label needs to be updated as well. Patch #26 updates both the contextual filter and the delete button label. I have also added a space in between sentences for the message.

Tested on 8.3.x and seems to be working fine.

Except the big bold title says "delete" and the rest of the words say "remove"

Updating test and re-applying patch.

+++ b/core/modules/block_content/src/Form/BlockContentDeleteForm.php
@@ -17,11 +18,18 @@ public function buildForm(array $form, FormStateInterface $form_state) {
-      '#markup' => $this->formatPlural(count($instances), 'This will also remove 1 placed block instance.', 'This will also remove @count placed block instances.'),
+      '#markup' => $this->formatPlural(count($instances), 'This will also remove 1 placed block instance. ', 'This will also remove @count placed block instances. '),

Why this change?

Also
PHP Parse error: syntax error, unexpected ')' in /var/www/html/core/modules/block_content/src/Tests/BlockContentListViewsTest.php on line 106

Yes I can see *what* it is doing, I asked *why* :)

Space was added as sentence that followed started immediately after the '.'

Syntax error fix. Removed the space as mentioned above.

@tim.clifford can you include interdiffs for your changes from now on? Thanks!
https://www.drupal.org/documentation/git/interdiff

+++ b/core/modules/block_content/block_content.links.contextual.yml
@@ -4,7 +4,7 @@ block_content.block_edit:
-  title: 'Delete'
+  title: 'Remove'

+++ b/core/modules/block_content/block_content.links.task.yml
@@ -17,7 +17,7 @@ entity.block_content.canonical:
-  title: Delete
+  title: Remove

+++ b/core/modules/block_content/block_content.routing.yml
@@ -30,7 +30,7 @@ entity.block_content_type.delete_form:
-    _title: 'Delete'
+    _title: 'Remove'

@@ -60,7 +60,7 @@ entity.block_content.delete_form:
-    _title: 'Delete'
+    _title: 'Remove'

+++ b/core/modules/block_content/src/Form/BlockContentDeleteForm.php
@@ -24,4 +25,11 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+  public function getConfirmText() {
+    return $this->t('Remove');
+  }

After trying to debug #2839558: Blocks do not have a "remove" contextual link, I realized that all of these changes are wrong.

None of these will just remove that placed block, they will delete the block content entity and ALL placements of the block. It is a destructive deletion of user-entered content, not a easily reversible configuration change.

Either this is won't fix, or the issue needs more clarification.

The title says it all.

Not quite :)

+1 to just remove

Taking a look as part of Global Sprint Weekend (Boston)...

I created 8.4.x sandbox with patch 46 (via simplytest.me). Verifying that following the placement of a custom block, the contextual editor options do not contain either a 'Remove' or 'Delete' option (see screenshot).

Committed and pushed to 8.4.x and backported to 8.3.x. Thanks!