Problem/Motivation

The usual wording of the button to add something is "Add content type", "Add contact form" etc. but on the two Display mode pages these links are "Add new view mode" and "Add new form mode".

"New" is otherwise only used in connection with installing something new (module, theme).

Proposed resolution

1) Change the wording to "Add view mode" on the View modes page, and to "Add form mode" on the Form modes page.

2) On the View modes page, remove 'new' from each of the following:
"Add new Content view mode", "Add new Custom block view mode", "Add new Comment view mode", "Add new Taxonomy term view mode", "Add new User view mode".

Remaining tasks

Edit the wording in the field_ui.routing.yml and/or field_ui.links.action.yml, and update the hook_help text in field_ui.module if necessary

User interface changes

This is a UI text change and therefore the help text might need to be edited as well.

API changes

none

Data model changes

none

CommentFileSizeAuthor
#11 2752709-10.patch1.9 KBpashupathi nath gajawada
#6 removed-new-from-view-and-form-modes-2752709-5.patch3.82 KBChandeepKhosa
#6 before-view-modes-1.jpg329.09 KBChandeepKhosa
#6 before-view-modes-2.jpg204.46 KBChandeepKhosa
#6 after-view-modes-1.jpg321.5 KBChandeepKhosa
#6 after-view-modes-2.jpg301.85 KBChandeepKhosa
#6 before-form-modes.jpg122.44 KBChandeepKhosa
#6 after-form-modes.jpg120.69 KBChandeepKhosa
#3 text-changed-2752709-3.patch675 byteskamalrajsahu21
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ifrik created an issue. See original summary.

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Assigned: Unassigned » ChandeepKhosa

..

kamalrajsahu21’s picture

kamalrajsahu21 CreditAttribution: kamalrajsahu21 at Intelliswift commented
FileSize
text-changed-2752709-3.patch675 bytes

Text changed in this patch and no need to change anything in help text.

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Issue summary: View changes

I noticed that the 'new' text needed to be removed from additional places, but on the same page & context, so I expanded the scope of this issue.

Haza’s picture

Haza
Primary language French
CreditAttribution: Haza at Happyculture commented
Status: Active » Needs work 
  1. +++ b/core/modules/field_ui/field_ui.links.action.yml
@@ -1,13 +1,13 @@
-  title: 'Add new view mode'

    I guess we should also change this in the tests.

    See in testEntityViewModeUI()

        $this->assertResponse(200);
    $this->assertText(t('Add new view mode'));
    $this->assertLinkByHref('admin/structure/display-modes/view/add');

  2. +++ b/core/modules/field_ui/field_ui.links.action.yml
@@ -1,13 +1,13 @@
+  title: 'Add form mode'

    Same here, see in testEntityFormModeUI().

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Assigned: ChandeepKhosa » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
FileSize
removed-new-from-view-and-form-modes-2752709-5.patch3.82 KB
after-form-modes.jpg120.69 KB
before-form-modes.jpg122.44 KB
after-view-modes-2.jpg301.85 KB
after-view-modes-1.jpg321.5 KB
before-view-modes-2.jpg204.46 KB
before-view-modes-1.jpg329.09 KB

This patch includes all relevant changes needed above.
Unlike the patch uploaded by Kamal, my patch also includes connected changes to tests & additional view modes lower on the page.

Thank you to Marc Van Gend (marcvangend), Daniel Smith (dmsmidt) & Gabor Hojtsy (gábor-hojtsy) for mentoring assistance here at Drupal Dev Days.

Screenshots showing changes made

View modes

Form modes

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented

..

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Looks good assuming tests pass :)

Status: Needs review » Needs work

The last submitted patch, 6: removed-new-from-view-and-form-modes-2752709-5.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Looks like still fails on Line 47 of core/modules/field/src/Tests/Update/FieldUpdateTest.php:.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Assigned: Unassigned » pashupathi nath gajawada
Status: Needs work » Needs review
FileSize
2752709-10.patch1.9 KB

Hi ,

Please find the attached patch which would fix this.

Thanks,

mcgovernm’s picture

mcgovernm CreditAttribution: mcgovernm as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Last patch looks good! Tested patch with simplytest.me.

ChandeepKhosa’s picture

ChandeepKhosa CreditAttribution: ChandeepKhosa at 2Toucans commented
Assigned: pashupathi nath gajawada » Unassigned

Thanks guys for all of your help. I am removing the assignee from pashupathi

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented

Thanks, this patch works as intended.

However, two comments about good practices in the issue queue:

Kamalrajsahu21: another user had already assigned himself to the issue and was working on it. Just jumping in and posting a patch without checking whether the other person had stopped working on it, means that the work was done double, potentially wasting time that rather could have been spend on two different issues.

And about naming patches: It's good practice to keep the name of the first patch and not just randomly rename them. A different name usually indicates a new patch done from scratch and not a continued work, so it's difficult for reviewers to see what's going on. For the same reason it's also good practice to provide interdiffs so that reviewers can see what has changed from one version of a patch to another instead of reviewing it all over again.

  • xjm committed d2cd3e6 on 8.2.x 
    Issue #2752709 by ChandeepKhosa, kamalrajsahu21, pashupathi nath...

xjm credited dmsmidt.

xjm credited marcvangend.

xjm credited dmsmidt.

xjm credited marcvangend.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Fixed

I confirmed that this fixes all instances of these two overlong strings:

[mandelbrot:maintainer | Thu 16:56:17] $ grep -ri "add new view mode" *
[mandelbrot:maintainer | Thu 16:56:20] $ grep -ri "add new form mode" *

Similarly to #2749261: "Add view" instead of "Add new view", this removes redundancy from the UI text, which is a good usability best practice.

Committed d2cd3e6 and pushed to 8.2.x. Thanks! I've also added issue credit for the mentors mentioned in the issue.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

(Fixing the credit.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -sprint

Thanks, removing from UX sprint now.