Fix visibility of AssertContentTrait::assertNoEscaped() [#2751711]

Similar to #2744089: Fix visibility of AssertLegacyTrait::assertLink() we need to fix the visibility of the mentioned method.

I'll attach a small patch for it. OG is failing on travis CI with the message

PHP Fatal error: Access level to Drupal\simpletest\AssertContentTrait::assertNoEscaped() must be public (as in class Drupal\Tests\BrowserTestBase) in /home/travis/build/amitaibu/og/og_ui/tests/src/Functional/BundleFormAlterTest.php on line 167

Comment	File	Size	Author
#4	2751711.patch	670 bytes	RoySegall
#4	8.2.x: PHP 5.5 & MySQL 5.5 18,539 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

19 June 2016 at 12:08

RoySegall created an issue. See original summary.

Comment #2

RoySegall CreditAttribution: RoySegall at Gizra commented 19 June 2016 at 12:09

Issue summary:

View changes

Comment #3

RoySegall CreditAttribution: RoySegall at Gizra commented 19 June 2016 at 12:09

Issue summary:

View changes

Comment #4

RoySegall CreditAttribution: RoySegall at Gizra commented 19 June 2016 at 12:20

Issue summary:	View changes
Status:	Active	» Needs review

File	Size
2751711.patch	670 bytes
8.2.x: PHP 5.5 & MySQL 5.5 18,539 pass

Comment #5

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 19 June 2016 at 15:57

Well, the other patch moves from public to protected, this from protected to public. There is some symmetry which is broken.

Comment #6

pfrenssen

Sofia

CreditAttribution: pfrenssen as a volunteer commented 20 June 2016 at 17:10

I had encountered the same failure in OG today. I didn't realize this was already reported, I created a duplicate issue (with exactly the same title as this one, funnily enough :) - #2752315: Fix visibility of AssertLegacyTrait::assertNoEscaped().

In my patch the visibility is inverted to this patch: it changes from public to protected to be consistent with the other assertions. So I guess I'll leave mine up even though it is newer.