Migrated custom block body field is hidden on form and display

Looks good!

Updated the migration templates.

1. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityDisplayTest.php
   @@ -0,0 +1,51 @@
   +/**
   + * Tests migration of block content body field display configuration.
   + *
   + * @group comment
   + */
   +class MigrateBlockContentEntityDisplayTest extends MigrateDrupal7TestBase {
   

   This test is in the wrong group.

2. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityDisplayTest.php
   @@ -0,0 +1,51 @@
   +  public static $modules = ['block', 'block_content', 'filter', 'text'];
   

   Should have @inheritdoc comment.

3. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityDisplayTest.php
   @@ -0,0 +1,51 @@
   +    $this->assertTrue(is_array($component));
   

   Let's use $this->assertInternalType('array', $component).

4. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityDisplayTest.php
   @@ -0,0 +1,51 @@
   +    $this->assertIdentical('hidden', $component['label']);
   

   Should be assertSame().

5. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityFormDisplayTest.php
   @@ -0,0 +1,51 @@
   +/**
   + * Tests migration of block content body field form display configuration.
   + *
   + * @group comment
   + */
   +class MigrateBlockContentEntityFormDisplayTest extends MigrateDrupal7TestBase {
   

   Wrong group, again.

6. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityFormDisplayTest.php
   @@ -0,0 +1,51 @@
   +  public static $modules = ['block', 'block_content', 'filter', 'text'];
   

   Needs @inheritdoc.

7. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityFormDisplayTest.php
   @@ -0,0 +1,51 @@
   +    $this->assertTrue(is_array($component));
   

   As before, should use assertInternalType().

8. +++ b/core/modules/block_content/tests/src/Kernel/Migrate/MigrateBlockContentEntityFormDisplayTest.php
   @@ -0,0 +1,51 @@
   +    $this->assertIdentical('text_textarea_with_summary', $component['type']);
   

   Should be assertSame().

I'm trying to find objectionable things in this patch but I can't. Well done, all!

Looks like a random failure to me , should be moved back to RTBC.

@gaurav.kapoor, I agree. Back to RTBC.

So these things are shipped with standard - what happens if this migration runs on standard? Do we get duplicates? Setting back to needs review to get an answer.

Assigning to myself to discover the answer to @alexpott's question.

This could also be a fairly easy novice. Apply the patch and manually try to migrate a D7 site into D8 and see if duplicate block fields appear.

@alexpott: The PerComponentEntityDisplay and PerComponentEntityFormDisplay destination plugins call entity_get_display() and entity_get_form_display(), respectively, so they should load the displays that ship with standard. Their shared base class then calls setComponent() on the display, so if the body field was already there, it will be overwritten with the incoming data rather than duplicated.

I'm not sure how else we could test this, beyond what we're already doing. So I think this can go back to RTBC.

I would have expected a change to \Drupal\migrate_drupal_ui\Tests\d6\MigrateUpgrade6Test::getEntityCounts() and the d7 version too. I guess that is not happening because the form and view displays are being created anyway by the creation of the block type. This is one of the reasons why these secondary configuration writes are tricky to manage and should be on the UI level and not the API. Makes it much easier to spot things like this - not the fault of the migration system though. What I can't work out atm is what code is actually responsible for creating the form and view displays magically.

There have been no updates. Drupal CI is just mocking us.

Committed and pushed 631e8d8 to 8.4.x and b9cdeaa to 8.3.x. Thanks!

As migrate is still experimental and this is an addition for something that is missing backporting to 8.3.x

@JohnOku, please open a follow-up support request. This has already landed and is fixed.