Views Exposed Filters should provide more specific cache contexts. [#2605038]

While working on #2596649: Exposed form does not save state when it is placed in a block I found out that views exposed filters provide broad cache contexts (they mark the URL as context). Their real context however is just specific query arguments on the URL, so they should provide url.query_args:*** as their cache context.

Attached patch fixes this, but will probably break tests.

Comment	File	Size	Author
	more-specific-exposed-filter-cache-contexts.patch	862 bytes	legolasbo
	8.0.x: PHP 5.5 & MySQL 5.5 14,279 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

30 October 2015 at 16:00

legolasbo created an issue. See original summary.

Comment #2

legolasbo

he/him

Dutch

Middelburg

CreditAttribution: legolasbo at Ibuildings commented 30 October 2015 at 16:44

Issue tags:

+Needs tests

Hmm, seems like the cache contexts for these filters don't have test coverage.

Comment #3

dawehner

German

CreditAttribution: dawehner as a volunteer commented 31 October 2015 at 15:34

I'm quite sure that this issue is a duplicate of some other issue, but I can't find the other issue at the moment. IMHO when this issue has a test, we could also just get this issue!

Comment #4

alexej_d CreditAttribution: alexej_d commented 31 October 2015 at 15:57

Probably it's the same as here Exposed form in a block rendered on another page than the view is displayed breaks the "Remember the last selection" option.

Comment #5

legolasbo

he/him

Dutch

Middelburg

CreditAttribution: legolasbo at Ibuildings commented 4 November 2015 at 12:39

@alexej_d,

I think the issue you mentioned is actually related to #2596649: Exposed form does not save state when it is placed in a block since the exposed form block doesn't currently provide any cache contexts. This issue is about the fact that the cacheContext exposed filters in general is currently the entire URL, while it should be specific URL arguments.