We recently upgraded from 4.4.4 to 4.5.3: #2521820: Update CKEditor library to 4.5.3.

4.5.4 has been released today: http://ckeditor.com/blog/CKEditor-4.5.4-Released

This is a bugfix-only release, with only minor fixes. Therefore I think it's okay to add this after RC1, hence tagged rc target.

See also:

CommentFileSizeAuthor
#7 ckeditor_4.5.4-2581291-7.patch1.18 MBwim leers
#2 ckeditor_4.5.4-2581291-2.patch1.01 MBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Active » Needs review
StatusFileSize
new ckeditor_4.5.4-2581291-2.patch1.01 MB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

Stressing the impact vs. disruption in the IS.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

I forgot to mention this in #2: CKEditor has updated its "CKBuilder" tool from version 2.1.0 to 2.3.0. They did the QA process of 4.5.4 with a CKEditor built by CKBuilder 2.3.0.

But #2 is built with 2.1.0 (I modified their build script to force it to use 2.1.0), because I couldn't get 2.3.0 to work. They've gotten back to me, apparently the reason is that CKBuilder 2.3.0 requires Java 7 or 8. OS X (10.9/10.10/10.11) has Java 1.6.

Which means that the CKEditor update in #2 may have subtle bugs/subtle differences compared to the CKEditor that was QA-tested before release. I'll need to update my machine first.

effulgentsia’s picture

effulgentsia commented
Issue tags: -rc target +rc eligible

I discussed this with @alexpott and @catch, and we decided to include patch-level-version library updates in the "rc eligible" category instead of "rc target". See https://www.drupal.org/core/d8-allowed-changes#rc for more details about the differences between the tags.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Even though we know 4.5.5 is coming soon, I do think it's valuable to already update to 4.5.4. Quoting myself at #2321583-15: Update CKEditor library to 4.5.5:

And now we have confirmation that the final CKEditor release before 8.0.0 will be CKEditor 4.5.5.

It will be released on November 11 (one week after RC3, one week before 8.0.0). I've got confirmation from several core committers that it's going to be okay to update to that version. Especially because it will contain some bugfixes that Drupal 8 needs, most notably:

I do think it's valuable for #2581291: Update CKEditor library to 4.5.4 to still go in in the mean time, because it will make the difference in CKEditor between 8.0.0 RC3 and 8.0.0 final smaller, thus further reducing the risk.

Therefore, now updating my Java installation (see #4) to build CKEditor 4.5.4.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new ckeditor_4.5.4-2581291-7.patch1.18 MB

Done! I didn't find any problems in manual testing. Nor should we, because the changelog is very short, and mostly fixing browser compatibility bugs:

## CKEditor 4.5.4

New Features:

* #13632: Post installation of html-area,(http://dev.ckeditor.com/ticket/13632): Introduce error logging mechanism.
* #13730: Create validate_id() and use everywhere possible.(http://dev.ckeditor.com/ticket/13730): Switch to the new error logging mechanism.

Fixed Issues:

* #9856: New Installation - Search not working(http://dev.ckeditor.com/ticket/9856): Fixed: Cannot use the native context menu together with the [Div Editing Area](http://ckeditor.com/addon/divarea) plugin. Thanks to [Mark Wade](https://github.com/mark-wade)!
* #12733: Grouping Nodes (Pages) Together.(http://dev.ckeditor.com/ticket/12733): [IE9+] Fixed: Radio button `onChange` does not work. Thanks to [Iliya Kostadinov](https://github.com/iliyakostadinov)!
* #13142: Themes attached to various sections not showing up-- default theme showing(http://dev.ckeditor.com/ticket/13142): [Edge] Fixed: *Ctrl+A* and then *Backspace* result in an empty `<div>` element.
* #13599: PHP highlighting and break tag(http://dev.ckeditor.com/ticket/13599): Fixed: Cross-editor drag and drop of an inline widget results in error/artifacts.
* #13640: Where is number of notes on frontpage defined?(http://dev.ckeditor.com/ticket/13640): [IE] Fixed: Dropping a widget outside the `<body>` element is not handled correctly.
* #13533: pushbutton - PHPTemplate version(http://dev.ckeditor.com/ticket/13533): Fixed: No progress during upload.
* #13680: allow variable_set to return a value(http://dev.ckeditor.com/ticket/13680): Fixed: The parser should allow the `<h1-6>` element to be a child of the `<summary>` element.
* #11724: Block titles have to be unique, which they shouldn't(http://dev.ckeditor.com/ticket/11724): [Touch devices] Fixed: Drop-downs often hide right after opening them.
* #13690: What date-time format to use in Drupal modules? How to identify the current user?(http://dev.ckeditor.com/ticket/13690): Fixed: Copying content from IE to Chrome adds an extra paragraph.
* #13284: Add address link invalid(http://dev.ckeditor.com/ticket/13284): Fixed: Cannot drag and drop a widget if the text caret is placed just after the widget instance.
* [#13516](http://dev.ckeditor.com/ticket/13516): Fixed: CKEditor removes empty HTML5 anchors without the `name` attribute.
* #13765: Taxonomy Access Control(http://dev.ckeditor.com/ticket/13765): [Safari 9] Fixed: Problems with rendering samples.
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

I did a bunch of manual testing too.
Enabled all available plugins and tested all of them one by one.
Nothing broken to declare.

  • catch committed c7a9c9a on 8.0.x 
    Issue #2581291 by Wim Leers: Update CKEditor library to 4.5.4
catch’s picture

catch
he/him
Primary language English
commented

Committed/pushed to 8.0.x, thanks!

Makes sense to get this into the next release candidate so it gets as much manual testing as possible.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you so much for the very fast commit, @catch!

On to CKE 4.5.5 in #2321583: Update CKEditor library to 4.5.5 next week.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.