Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is blocked on #2540850: (regression) EditorImageDialog alignment & captioning are not working.
It's been a long time (more than six months) since we last updated CKEditor: #2415111: Update CKEditor library to 4.4.7.
At the beginning of July, CKEditor 4.5 was released. Since then, three point (bugfix) releases have been made, so we're now at CKEditor 4.5.3.
CKEditor 4.5 brought two important new features. Bringing those to Drupal 8 core is for a separate issue, hopefully for Drupal 8.1. Issues opened:
In addition, CKEditor 4.5 added support for the new Microsoft Edge browser available in Windows 10.
CKEditor 4.5.3 specifically also improved pasting from Microsoft Word, so after this lands, we should re-evaluate #1955300: Ensure CKEditor's "Paste From Word" feature works stellarly before Drupal 8 release.
See also:
- #1858210: [meta] Content editing experience follow-ups — in-place editing and WYSIWYG
- #1950098: Update CKEditor library to 4.1
- #2036253: Update CKEditor library to 4.2
- #2039163: Update CKEditor library to 4.4
- #2271051: Update CKEditor library to 4.4.4
- #2345961: Update CKEditor library to 4.4.5
- #2384581: Security: Update CKEditor library to 4.4.6
- #2415111: Update CKEditor library to 4.4.7
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | ckeditor_4_5_3-2521820-16___ckeditor-update-2561119-10280581-1___interdiff.patch | 2.25 MB | vprocessor |
| |||
| #16 | ckeditor_4.5.3-2521820-16.patch | 2.42 MB | Wim Leers |
Comments
Comment #1
dawehnerUpdating libraries is not critical per #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0
Comment #2
TJacksonVA CreditAttribution: TJacksonVA commented@dawehner, normally I would be fully supportive of that. However, apparently only CKEditor 4.5 will have Microsoft Edge browser support. Since Windows 10 will be released on July 29th, and the standard browser will be the Edge browser, I would think it would be at least a Major priority as without CKEditor 4.5.x, Drupal 8.0.x will not work with a major browser.
In any event, I defer to your judgment.
Comment #3
nod_It is important and we're very much interested in updating it. Status are just internal policies.
We're tracking this, it's important to us too.
Comment #4
TJacksonVA CreditAttribution: TJacksonVA commentedAnd apparently they have issued CKEditor 4.5.1 just a day later to fix one bug:
#13486: Fixed: The Upload Image plugin should log an error, not throw an error when upload URL is not set.
CKEditor 4.5.1
Comment #5
TJacksonVA CreditAttribution: TJacksonVA commentedComment #6
TJacksonVA CreditAttribution: TJacksonVA commentedComment #7
TJacksonVA CreditAttribution: TJacksonVA commentedAlong the lines of supporting the new Microsoft Edge browser in Windows 10, the current development version of CKEditor 4.5.2 has at least 7 ticket items relating to the Edge browser.
CKEditor 4.5.2 development version
Comment #8
TJacksonVA CreditAttribution: TJacksonVA commentedThe folks at CKEditor have just closed out CKEditor 4.5.2, which should be released on August 3, 2015. This release contains 34 fixes, including several more fixes for the new Microsoft Edge browser in Windows 10. I will post the link as soon as it is available.
Comment #9
TJacksonVA CreditAttribution: TJacksonVA commentedAnd they have now released CKEditor 4.5.2: CKEditor 4.5.2
Since this contains additional fixes for the Edge browser, this would be worthwhile to get into the Drupal 8 beta.
And here is a description of the changes: CKEditor 4.5.2 Released
Comment #10
TJacksonVA CreditAttribution: TJacksonVA commentedComment #11
TJacksonVA CreditAttribution: TJacksonVA commentedUpdated Parent issue.
Comment #12
TJacksonVA CreditAttribution: TJacksonVA commentedUpdated issue to CKEditor 4.5.3 which was released today.
Comment #13
andypostAdded roadmap to IS http://dev.ckeditor.com/roadmap
Comment #14
Wim LeersUpdating the IS to be consistent with prior issues like this one. Opened issues to support CKEditor's new features in 8.1.
Also, taking on rolling this patch.
Comment #15
webchickThis sounds at least major because it deals with #1955300: Ensure CKEditor's "Paste From Word" feature works stellarly before Drupal 8 release.
Comment #16
Wim LeersDone. Seems to work well. But… until #2540850: (regression) EditorImageDialog alignment & captioning are not working is fixed, we cannot actually properly test this… :(
Comment #17
TJacksonVA CreditAttribution: TJacksonVA commentedComment #18
TJacksonVA CreditAttribution: TJacksonVA commentedComment #19
Wim LeersThanks, @TJacksonVA, good IS updates :)
Note that in my manual testing, this is working correctly, but the most crucial test is actually image captions/alignment, which is exactly what I can't test until #2540850: (regression) EditorImageDialog alignment & captioning are not working is fixed.
Comment #20
andypostThere's a duplicate issue filed #2561119: Update CKEditor library to 4.5.3 the main difference in plugin amount shipped - it makes sense to discus while waiting for #2540850: (regression) EditorImageDialog alignment & captioning are not working
Comment #21
vprocessor CreditAttribution: vprocessor at Skilld commentedHi Wim, please check interdiff with my patch
This works properly and has all new ckeditor plugins like in old version
Comment #22
Wim Leers#21: #16 already is a working patch! This is blocked on #2540850: (regression) EditorImageDialog alignment & captioning are not working.
Comment #24
Wim LeersIgnore #21, #16 is the right patch.
Comment #25
Wim LeersWe'll be able to fix #2276187: Remove the CKEditor readonly attribute support work-around once this lands, yay :)
Comment #26
Wim LeersWe just got confirmation that this patch (so simply updating to CKE 4.5) fixes a nasty WTF when pasting from Word or other rich text editors: #2516932-5: When pasting from Word, empty paragraphs were created. So, also tagging usability :)
Comment #27
Wim LeersComment #28
effulgentsia CreditAttribution: effulgentsia at Acquia commentedThis is a minor version update, not just a patch release update, so promoting to Critical, per #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0.
Comment #29
xjmWhich issue is this postponed on? Can we put that in the summary?
Comment #30
Wim LeersComment #31
DuaelFrThis issue seems to be blocking #2510380: Images cannot be linked in CKEditor which is, IMHO, a release blocker if we don't want to go back in the darkest depths of the Internet.
Users won't ever understand why the hell they cannot put a link on their magnificent kitten-friendly animated GIF ;)
Comment #32
Wim Leers#2540850: (regression) EditorImageDialog alignment & captioning are not working now has a fix. Will do the necessary manual JS testing ASAP.
Comment #33
Wim LeersI was able to thoroughly test it thanks to #2540850: (regression) EditorImageDialog alignment & captioning are not working having a fix.
I was not able to find any regressions, everything WRT image alignment & captioning is still working perfectly! :)
Therefore, unpostponing, and marking needs review, because I can't RTBC this patch. Will need somebody to also do a round of basic manual testing. Note that manual testing of pasting from Word and other rich text editors was already done at #2516932-5: When pasting from Word, empty paragraphs were created and found that CKEditor 4.5.3 made significant improvements :)
Comment #34
kattekrab CreditAttribution: kattekrab at Creative Contingencies commentedI've done some manual testing of the patch.
Used Basic HTML and Full HTML options on the article content type.
Enabled ALL THE THINGS possible via drag drop in the text format config thing.
Fooled around a bit with pasting from Pages and OpenOffice (I don't have msword)
Seems to work ok. If there's some more specific things I should be testing for, and a list I can follow, I'd be happy to do some more thorough testing too.
But as far as it goes, this looks ok to me!
Comment #35
webchickThat sounds like an RTBC to me. :)
Committed and pushed #16 to 8.0.x. Thanks!
Comment #38
Wim LeersNow upgrading to 4.5.4: #2581291: Update CKEditor library to 4.5.4.