The responsibilities of a core maintainer have been updated (see #2457875: [policy] Evolving and documenting Drupal core's structure, responsibilities, and decision-making), and all components/subsystems are in need of updating. We should discuss any needed updates to the theme subsystem.

This is the current list:

Theme system
- Alex Bronstein 'effulgentsia' https://www.drupal.org/u/effulgentsia
- John Albin Wilkins 'JohnAlbin' https://www.drupal.org/u/johnalbin
- Jen Lampton 'jenlampton' https://www.drupal.org/u/jenlampton
- Scott Reeves 'Cottser' https://www.drupal.org/u/cottser
- Fabian Franz 'Fabianx' https://www.drupal.org/u/fabianx
- Joël Pittet 'joelpittet' https://www.drupal.org/u/joelpittet

We should discuss removing Alex, John, and Jen. They are all very awesome people, and we would not have gotten here without them, but they have not been very active in the theme system for some time. If any are to stay, including Scott, Fabian, and Joël, we need to verify that they have read the maintainer policy changes, and are willing to serve in accordance with the newly defined role.

Also, lets discuss any people that should be added to the list.

CommentFileSizeAuthor
#19 update_theme_system-2512442-19.patch714 byteslauriii
#15 update_theme_system-2512442-15.patch1.01 KBjenlampton
#12 update_theme_system-2512442-12.patch1.01 KBJohnAlbin
#5 update_theme_system-2512442-5.patch490 bytesdavidhernandez
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented

Regarding additions, I recommend adding lauriii (https://www.drupal.org/u/lauriii).

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented

I am up to working as a theme system maintainer :)

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer commented

Yup, I am okay with the policy.

mortendk’s picture

mortendk CreditAttribution: mortendk as a volunteer commented

+1 & a fistbumb on adding laurii as maintainer (even that he breaks all the stuff all the time :P )

This list will be the people that have been in the deep engine room for the last couple of years when twig got implemented so a huge +1

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented
Status: Active » Needs review
FileSize
update_theme_system-2512442-5.patch490 bytes

Patch to add Lauri.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer commented
Status: Needs review » Reviewed & tested by the community

RTBC, looks good to me.

Thanks, laurii.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented

RTBC++, good to have you there @lauriii

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Reviewed & tested by the community » Needs review

Are we supposed to discuss removing the inactive maintainers in this issue?

mortendk’s picture

mortendk CreditAttribution: mortendk as a volunteer commented

more finish more fun!

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented

Yes, not sure the best way to deal with that but here's a stab. Haven't contributed in the last 6 months on theme system issues as the main criteria:
https://www.drupal.org/project/issues/search/drupal?project_issue_follow...
https://www.drupal.org/project/issues/search/drupal?project_issue_follow...
https://www.drupal.org/project/issues/search/drupal?project_issue_follow...
https://www.drupal.org/project/issues/search/drupal?project_issue_follow...
https://www.drupal.org/project/issues/search/drupal?project_issue_follow...
https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

Of which @JohnAlbin and @jenlampton are the only two that fit into that criteria and the one described in the policy. Hopefully that is fair and I'll try to ping them to see if that is. (I only looked at the updates in the last month because the search doesn't help narrow down last comments)

@effulgentsia has been pivotal in the SafeMarkup part of the theme system of recent. @Fabianx in the performance as well as other hard problems.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented

I accept the terms and conditions :)

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at PreviousNext commented
FileSize
update_theme_system-2512442-12.patch1.01 KB

I'm sad to see my name leave the "Theme System" section with all the work I've done in the past for the theme system, but the MAINTAINERS file is for _current_ maintainers. And, fortunately, I haven't had to work on the theme system because YOU ALL HAVE BEEN AWESOME!

When I jump back into Drupal core issues (I've been focusing on style guides for the past year), my focus is going to be on the CSS rather than the PHP bits of the theme system, so I'm good with removing my name.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented

@JohnAlbin thank you for your help with the theme system it is much appreciated! and gladly RTBC you back into any system you want to maintain! And we have you in there for CSS with Lewis still, so I'm glad to see that.

mortendk’s picture

mortendk CreditAttribution: mortendk as a volunteer commented

John believe me your not off the hook there's a standing rtbc
and a ton of thanx for pushing with us
.... btw where's those 20$

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton as a volunteer commented
FileSize
update_theme_system-2512442-15.patch1.01 KB

I also agree that since the MAINTAINERS file is for _current_ maintainers I should be removed.

Unlike @JohnAlbin, I have no plans to return to core development in the future, so removing myself from MAINTAINERS.txt is doubly heart wrenching for me. Making it here was a huge honor. Drupal truly changed my life many times over, and I wouldn't trade any of the time I've spent with all of you in issue queues, IRC, google hangouts or sprints for anything else.

I feel honored to have been one of the mighty Twig team, grateful that you followed my lead in the early days, and proud that you have long since moved past needing me involved. I would like to second the comment that YOU ALL HAVE BEEN AWESOME - because you have, and you still are!!!

Carry on with the good work, and I'll see you in the D7 queues :)

Status: Needs review » Needs work

The last submitted patch, 15: update_theme_system-2512442-15.patch, failed testing.

Status: Needs work » Needs review

Manjit.Singh queued 15: update_theme_system-2512442-15.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 15: update_theme_system-2512442-15.patch, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Needs work » Needs review
FileSize
update_theme_system-2512442-19.patch714 bytes
mortendk’s picture

mortendk CreditAttribution: mortendk as a volunteer commented
Status: Needs review » Reviewed & tested by the community

can we do a --force on jen to get her back on the mighty team-twig ?
asking for a friend

Also with a bit of sadness in my dark dark heart but guess its rtbc to keep up with having active maintainers n all

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented

We should check with Alex Bronstein if he still wants to be listed.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented

<3

Thank you @jenlampton for being awesomely inspiring and welcoming and all you have done and continue to do!

Big hugs to all the Twig team past present and future :)

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer commented

Thank you Jen and John!

You are awesome!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Assigned: Unassigned » Dries

@Dries handles MAINTAINERS.txt changes.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 19: update_theme_system-2512442-19.patch, failed testing.

Status: Needs work » Needs review

LewisNyman queued 19: update_theme_system-2512442-19.patch for re-testing.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Random testbot fail I guess.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 19: update_theme_system-2512442-19.patch, failed testing.

Status: Needs work » Needs review

alexpott queued 19: update_theme_system-2512442-19.patch for re-testing.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented
Status: Needs review » Reviewed & tested by the community

  • Dries committed ab15cc4 on 8.0.x 
    Issue #2512442 by davidhernandez, lauriii, JohnAlbin, jenlampton: Update...
Dries’s picture

Dries CreditAttribution: Dries commented
Assigned: Dries » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.