Problem/Motivation
When clicking through the config translation, suddenly, certain config types suggest to "Manage fields | form display | display". Additionally, "Manage fields" is the default value instead of "Translate". This confuses users. The primary/sole purpose of this UI is to "Translate".
Proposed resolution
Remove the "Manage *" links in the config translation UI.
(Make sure the alteration of the links from the entity / field UI does not apply for config translation.)
Remaining tasks
Add tests.
User interface changes
BEFORE:
AFTER:
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#18 | 2462907-18.patch | 6.03 KB | tstoeckler |
#14 | 2462907-14--test-only.patch | 5.19 KB | tstoeckler |
#8 | Content type | drupal 8.0.x 2015-06-16 12-42-31.png | 66.87 KB | Gábor Hojtsy |
Comments
Comment #1
miro_dietikerProviding a screenshot.
Comment #2
penyaskitoAttached patch reorders them, so "Translate" is the first one (and default) if it exists.
I'm wondering anyway if we should remove the others, as we don't want users to lose focus of what are they doing at the moment.
Comment #5
miro_dietikerConfirming that Translate is the first item with this patch. Thx!
Comment #6
Gábor HojtsyCan we remove the rest of the items instead? We worked pretty hard to remove them and this appears because it alters them in... Not good IMHO :/ Its confusing because other things don't have their other operations.
Comment #7
penyaskitoIf there is a translate operation, remove the others.
Comment #8
Gábor HojtsyTested this manually. Looks good.
Needs tests. Updated issue summary. I don't think this needs usability review, it does what the rest of these screens do.
Comment #9
Gábor HojtsyBTW also found #2506793: Config translation shows search field below table while reviewing this. Should be easy to fix I hope :)
Comment #10
tstoecklerWe already have code to do this, but it operates too early so that the dynamic operations from field UI are still added afterwards. See attached patch.
Comment #11
tstoecklerAhh
ConigTranslationOverviewTest
doesn't enablefield_ui
module, that's why the test-only patch doesn't fail. Not sure whether we want to accept the performance cost of enabling it, just for this test. Hmm...Comment #12
penyaskitoThat test already enables views_ui... I don't think is such an impact.
Comment #13
Gábor HojtsyYeah I an not concerned of needing to enable field_ui :)
Comment #14
tstoecklerSo I was wrong: just enabling
field_ui
doesn't cut it, because theconfig_test
entity type does not have thebundle_of
property.So in order to properly test this, I added a
entity_test_operation
module that provides a test entity operation unconditionally. In order do that I also had to fix the API documentation.This time the test-only patch should actually fail.
Comment #16
Gábor HojtsyLooks good except:
Either?
Should be hidden: true, no?
Comment #17
tstoeckler1. Ahhh I had seen that and then forgot. You eagle-eye! ;-P Will fix later
2. Our test modules no longer have
hidden: true
because they are not discovered anyway, unless you set$settings['extension_discovery_scan_tests'] = TRUE;
explicitly in which case it's useful if they show up in the UI (we then collapse the Testing details element by default so it's not such a nuisance). So that should be fine.Comment #18
tstoecklerHere we go.
Comment #19
Gábor HojtsyYay, thanks! I grepped for hidden: true in test modules, and we still have that around quite a bit, but the reason I needed to grep in the first place was I was unsure :D
Comment #21
Gábor HojtsyFails seem to be unrelated:
Comment #23
Gábor HojtsyComment #24
alexpottNice test coverage and docs improvements. This issue addresses a normal bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 88a73d8 and pushed to 8.0.x. Thanks!
Comment #26
Gábor HojtsySuperb, thanks!