Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.user_save has a parameter named $array.. this is possibly the worst parameter name ever, so I renamed it to $fields to more accurately reflect it's purpose.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | user_save_parameter.patch | 7.39 KB | beeradb |
| #5 | user_save_parameter_rename-237381-5.patch | 7.09 KB | floretan |
| #3 | user_save_parameter_rename0.patch | 7.28 KB | beeradb |
| user_save_parameter_rename.patch | 7.2 KB | beeradb |
Comments
Comment #1
floretan commentedThe only reason I have not to mark this as RTBC is because $fields might need to be changed again if fields make it into core. What about using $edit which is also used by other *_save() functions in core?
Comment #2
dmitrig01 commentedComment #3
beeradb commentedrenamed $fields to $edit. I actually thought $fields might have been a poor choice last evening, but wasn't at a computer.
Comment #4
webchick+ * The $user object for th$edite user to modify or add. If $user->uid is
If I wasn't in the middle of doing SoC stuff atm, I'd re-roll myself. :P
Comment #5
floretan commentedIt took me some time to figure out that the comment above was referring to a line in the patch... I first thought it was webchick writing in a hurry :-)
I'm not in the middle of SoC stuff, so here's a re-roll.
Comment #6
floretan commentedComment #7
beeradb commentedpatch was stale, here's a re-roll
Comment #8
floretan commentedPatch works and looks good.
Comment #9
catchStill applies with offset.
Comment #10
dries commentedCommitted to CVS HEAD. Looks good, tests still work, better variable name. What is not to like? :P
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.