Move DrupalKernel::initializeCookieGlobals() into a SessionConfiguration service

Most of this is out of my wheelhouse, so I cannot RTBC it. I didn't notice anything major from a read through, though. Just a few doc related comments below:

1. +++ b/core/lib/Drupal/Core/Session/SessionConfiguration.php
   @@ -0,0 +1,193 @@
   +  /**
   +   * Constructs a new session configuration instance.
   +   *
   +   * @param array $options
   +   *   An associative array of session ini settings.
   +   *
   +   * @see \Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage::__construct()
   +   */
   

   Can we also add a @see to the PHP documentation on what those ini settings are?

2. +++ b/core/lib/Drupal/Core/Session/SessionConfiguration.php
   @@ -0,0 +1,193 @@
   +    // Per RFC 2109, cookie domains must contain at least one dot other than the
   +    // first. For hosts such as 'localhost' or IP Addresses we don't set a
   +    // cookie domain.
   

   Please link to the RFC.

   Although according to Wikipedia that RFC has been obsoleted for a long time, and there are multiple more recent RFCs to reference instead:

   http://en.wikipedia.org/wiki/HTTP_cookie

3. +++ b/sites/default/default.services.yml
   @@ -1,4 +1,40 @@
    parameters:
   +  session.storage.options:
   +    # Default ini options for sessions.
   +    #
   

   Ooo...

HTTPS mixed mode has been removed.

1. +++ b/core/lib/Drupal/Core/Session/SessionConfiguration.php
   @@ -0,0 +1,161 @@
   +  protected function getCookieDomain(Request $request) {
   +    if (isset($this->options['cookie_domain'])) {
   

   The IS has to describe that we change global $cookie_domain; and converts it into a container parameter. I can't think of a usecase where this cookie domain has to be dynamic ... on top you probably rely on the host most of the time anyway.

2. +++ b/core/lib/Drupal/Core/Session/SessionConfigurationInterface.php
   @@ -0,0 +1,38 @@
   +  /**
   +   * Determines whether this request is potentially associated with a session.
   +   *
   

   I wonder whether we can specify was potentially means.

3. +++ b/core/tests/Drupal/Tests/Core/Session/SessionConfigurationTest.php
   @@ -0,0 +1,252 @@
   +class SessionConfigurationTest extends UnitTestCase {
   

   Impressive test coverage!

4. +++ b/sites/default/default.services.yml
   @@ -1,4 +1,40 @@
   +    # between your various domains. Make sure to always start the $cookie_domain
   +    # with a leading dot, as per RFC 2109.
   

   seriously RFC!

Looks great! +1 to RTBC

Only one minor nit:

+++ b/core/tests/Drupal/Tests/Core/PageCache/NoSessionOpenTest.php
@@ -19,11 +19,11 @@
-   * @var string
+   * @var \Drupal\Core\Session\SessionConfigurationInterface|\PHPUnit_Framework_MockObject_MockObject

I don't think we ever list the mock object as a var possibility, do we? If it's a mock that should be transparent, and conform to that interface anyway, no?

Otherwise I am comfortable here.

Why in the name of Zork are we doing that...?

(If we are, then that shouldn't block this issue but it's nonsensical for us to be doing in the first place, IMO.)

*sigh* Durpal.

Yeah, its a huge DX win for you, if you have documented the types.

Reroll, minor conflict in WebTestBase.

The question from crell got answered

Committed 9a6582b and pushed to 8.0.x. Thanks!

diff --git a/core/lib/Drupal/Core/PageCache/DefaultRequestPolicy.php b/core/lib/Drupal/Core/PageCache/DefaultRequestPolicy.php
index fd79505..aec8d45 100644
--- a/core/lib/Drupal/Core/PageCache/DefaultRequestPolicy.php
+++ b/core/lib/Drupal/Core/PageCache/DefaultRequestPolicy.php
@@ -21,7 +21,7 @@ class DefaultRequestPolicy extends ChainRequestPolicy {
   /**
    * Constructs the default page cache request policy.
    *
-   * @param \Drupal\Core\Session\SessionConfiguration $session_configuration
+   * @param \Drupal\Core\Session\SessionConfigurationInterface $session_configuration
    *   The session configuration.
    */
   public function __construct(SessionConfigurationInterface $session_configuration) {
diff --git a/core/lib/Drupal/Core/Session/SessionConfiguration.php b/core/lib/Drupal/Core/Session/SessionConfiguration.php
index 7e4a8ce..9de1603 100644
--- a/core/lib/Drupal/Core/Session/SessionConfiguration.php
+++ b/core/lib/Drupal/Core/Session/SessionConfiguration.php
@@ -61,6 +61,9 @@ public function getOptions(Request $request) {
   /**
    * Returns the session cookie name.
    *
+   * @param \Symfony\Component\HttpFoundation\Request $request
+   *   The request.
+   *
    * @return string
    *   The name of the session cookie.
    */
diff --git a/core/lib/Drupal/Core/Session/SessionConfigurationInterface.php b/core/lib/Drupal/Core/Session/SessionConfigurationInterface.php
index 417ffd4..413b8f8 100644
--- a/core/lib/Drupal/Core/Session/SessionConfigurationInterface.php
+++ b/core/lib/Drupal/Core/Session/SessionConfigurationInterface.php
@@ -35,6 +35,9 @@ public function hasSession(Request $request);
    *
    * @see \Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage::__construct()
    *
+   * @param \Symfony\Component\HttpFoundation\Request $request
+   *   The request.
+   *
    * @return array
    *   An associative array of session ini settings.
    */

Fixed some docblocks on commit.