Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2285413: [Meta] Standardize entity route names
Problem/Motivation
Original meta issue needs this follow-up to clean-up field_ui provided routes
Proposed resolution
Extract changes from #2281645: Make entity annotations use link templates instead of route names
Remaining tasks
file a patch
User interface changes
None.
API changes
field_ui routes will have different names.
Beta phase evaluation
Issue category | Task, because the field_ui routes simply got forgotten, when many of the other routes got renamed |
---|---|
Issue priority | Normal, because this will "just" allow auto-generation of this limited amount of routes. |
Disruption | Tiny disruption, due to renamed routes. The amount of code which links to some field UI routes is probably quite limited. |
Comment | File | Size | Author |
---|---|---|---|
#24 | 2346883-24.patch | 5.57 KB | amateescu |
Comments
Comment #1
m1r1k CreditAttribution: m1r1k commentedComment #2
andypostfix routes for entity view|form displays
Comment #3
andypostMakes sure that entity has bundle, suppose the scope allows
PS: working to fix routes for fields
Comment #4
Crell CreditAttribution: Crell commentedThis looks fine to me, but it's unclear from the comment in #3 if you are still working on something or if you're clarifying what it's for. :-) Should I RTBC it or is there another patch coming?
Comment #5
andypostPatch is not ready, there's routes for field and field config, also this affects content translation which routes needs some clean-up... see comment in #2281645-81: Make entity annotations use link templates instead of route names
The CT routes are tricky but affected by field_ui so probably better to fit them here too
Comment #6
dawehnerTo be honest I don't get why we want to extract those here as well, given that you have to adapt config translation at the same time as well (yes, believe me).
This issue is for me at least, sorry andypost, a sign of overusing formal issue queue structures/"best" practices.
Comment #7
andypost@dawehner I mostly agree, in my vision routes should be renamed in separate issue under the meta
We need to standardize routes without dependency on link templates.
PS: will back to patch next weekend
Comment #8
andypostI'd still prefer to separate route rename issues from logic changes
Comment #9
Crell CreditAttribution: Crell commentedSo is another patch forthcoming here?
Comment #10
andypostComment #11
dawehner@andypost
What is the status of the issue? You assigned it to yourself ... but nothing happened. Do you still work on a new version of the patch?
Comment #13
kgoel CreditAttribution: kgoel commentedThis doesn't re-roll as patch still applies but testbot will tell. Correct me if I am wrong but config translation can be address in a separate issue so things can move forward.
Comment #14
dawehnerThe patch still works, let's get it in.
Comment #17
andypostre-roll after #2281645: Make entity annotations use link templates instead of route names
Comment #18
andypost@dawehner is
add-form
template is needed?the only missing part in last patch, not sure is needed
Comment #19
dawehnerWe do have at least one call to it:
in
VocabularyListBuilder
Comment #20
andypostOnce this entities have add forms it makes sense to expose them as templates too
This is just a rename
Comment #21
andypostneeds feedback
Comment #22
dawehner+1
Comment #24
amateescu CreditAttribution: amateescu commentedRerolled.
Comment #25
alexpottThis issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.
I think this is a followup from the critical work on entity url templates so is allowed.
Comment #26
dawehnerAdded it.
Comment #29
andypostComment #30
alexpottI see this as a followup to #2281645: Make entity annotations use link templates instead of route names and therefore committable under the followup rules of beta evaluation. Committed 275de46 and pushed to 8.0.x. Thanks!