Attaching before and after screenshots from #1972122: Remove the DIV tag around block content patch #41 (splitting apart and earlier combination of changes).

CommentFileSizeAuthor
#1 bartik-new-template.png54.51 KBakalata
#1 2342005-bartik-add-block-div-1.patch2.11 KBakalata
bartik-after.png60.97 KBakalata
bartik-before.png60.5 KBakalata

Comments

akalata’s picture

akalata commented
Component: theme system » Bartik theme
Status: Active » Needs review
StatusFileSize
new 2342005-bartik-add-block-div-1.patch2.11 KB
new bartik-new-template.png54.51 KB

Keeping things simple, instead of updating the Bartik CSS to look right with the div removed, let's just add the div in Bartik's block.html.twig.

akalata’s picture

akalata commented
Status: Needs review » Closed (won't fix)

Rolling back into #1972122: Remove the DIV tag around block content after discussion with @joelpittet.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Closed (won't fix) » Postponed

Postponing on #1972122: Remove the DIV tag around block content Let's use this to remove and cleanup the CSS around blocks without that content div here.

Title still sounds like the goal to me:)

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Postponed » Active

Ok, that's fixed.

joelpittet queued 1: 2342005-bartik-add-block-div-1.patch for re-testing.

Status: Active » Needs work

The last submitted patch, 1: 2342005-bartik-add-block-div-1.patch, failed testing.

akalata’s picture

akalata commented
Status: Needs work » Closed (won't fix)

Based on how we solved #1972122, we don't need to do anything here.