Problem/Motivation

@todo from #2301317: MenuLinkNG part4: Conversion
@todo Move this under menu_link_content module.

Proposed resolution

Move LinksTest to menu_link_content module

Remaining tasks

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#3 move_linkstest_to-2310353-3.patch950 bytescilefen
#3 interdiff-1-3.txt443 bytescilefen
#1 move_linkstest_to-2310353-1.patch954 bytescilefen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
FileSize
move_linkstest_to-2310353-1.patch954 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Thank you for the patch.

  1. +++ b/core/modules/menu_link_content/src/Tests/LinksTest.php
@@ -2,10 +2,10 @@
- * Definition of Drupal\system\Tests\Menu\LinksTest.
+ * Definition of Drupal\menu_link_content\Tests\LinksTest.

    We could fix it and use "Contains \..." directly. 

  2. +++ b/core/modules/menu_link_content/src/Tests/LinksTest.php
@@ -15,9 +15,6 @@
- *
- * @todo Move this under menu_link_content module.
- *   https://www.drupal.org/node/2310353
  */

    yeah, one less todo!

cilefen’s picture

cilefen CreditAttribution: cilefen commented
FileSize
interdiff-1-3.txt443 bytes
move_linkstest_to-2310353-3.patch950 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Cool

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 9b8c385 and pushed to 8.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 9b8c385 and pushed to 8.x. Thanks!

  • alexpott committed 9b8c385 on 8.0.x 
    Issue #2310353 by cilefen | YesCT: Move LinksTest to menu_link_content...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.