Helper issue for #2287727: Rename FieldConfig to FieldStorageConfig

CommentFileSizeAuthor
#34 2295803-32.patch495.15 KBswentel
#32 2287727-rename_FieldConfig-57.patch561.54 KBswentel
#30 2295803-30.patch494.69 KBswentel
#28 2295803-28.patch561.54 KBswentel
#22 2295803-helper_for_2287727-22.patch494.02 KBswentel
#19 2295803-helper_for_2287727-18.patch493.45 KBswentel
#17 2295803-helper_for_2287727-17.patch493.75 KByched
#16 2295803-helper_for_2287727-16.patch493.5 KByched
#14 2295803-helper_for_2287727-14.patch493.5 KByched
#13 2295803-helper_for_2287727-13.patch485.57 KByched
#11 2295803-helper_for_2287727-11.patch483.77 KByched
#10 2295803-helper_for_2287727-10.patch480.37 KByched
#8 2295803-helper_for_2287727-8.patch479.04 KByched
#6 2295803-helper_for_2287727-6.patch450.59 KByched
#3 2295803-helper_for_2287727-3.patch436.84 KByched
#2 2295803-helper_for_2287727-2.patch422.96 KByched
#1 2295803-helper_for_2287727-1.patch337.55 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
FileSize
2295803-helper_for_2287727-1.patch337.55 KB
yched’s picture

yched CreditAttribution: yched commented
FileSize
2295803-helper_for_2287727-2.patch422.96 KB

- changed $values['field'] to $values['field_storage'] in entity_create('field_instance_config', $values)
- More var renames

Will post the interdiff in the main issue when green.

yched’s picture

yched CreditAttribution: yched commented
FileSize
2295803-helper_for_2287727-3.patch436.84 KB

More renames - I think I got all those that can be found by pattern searching.

Status: Needs review » Needs work

The last submitted patch, 3: 2295803-helper_for_2287727-3.patch, failed testing.

The last submitted patch, 2: 2295803-helper_for_2287727-2.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
2295803-helper_for_2287727-6.patch450.59 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2295803-helper_for_2287727-6.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
2295803-helper_for_2287727-8.patch479.04 KB

Status: Needs review » Needs work

The last submitted patch, 8: 2295803-helper_for_2287727-8.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
2295803-helper_for_2287727-10.patch480.37 KB
yched’s picture

yched CreditAttribution: yched commented
FileSize
2295803-helper_for_2287727-11.patch483.77 KB

Status: Needs review » Needs work

The last submitted patch, 11: 2295803-helper_for_2287727-11.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
2295803-helper_for_2287727-13.patch485.57 KB
yched’s picture

yched CreditAttribution: yched commented
FileSize
2295803-helper_for_2287727-14.patch493.5 KB

Status: Needs review » Needs work

The last submitted patch, 14: 2295803-helper_for_2287727-14.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
2295803-helper_for_2287727-16.patch493.5 KB
yched’s picture

yched CreditAttribution: yched commented
FileSize
2295803-helper_for_2287727-17.patch493.75 KB

Status: Needs review » Needs work

The last submitted patch, 17: 2295803-helper_for_2287727-17.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
2295803-helper_for_2287727-18.patch493.45 KB

Should fix the error

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 19: 2295803-helper_for_2287727-18.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
2295803-helper_for_2287727-22.patch494.02 KB

Oh comment.php

Status: Needs review » Needs work

The last submitted patch, 22: 2295803-helper_for_2287727-22.patch, failed testing.

Status: Needs work » Needs review

swentel queued 22: 2295803-helper_for_2287727-22.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 22: 2295803-helper_for_2287727-22.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented

I don't get it, it's green on my local machine, one last retest :/

Status: Needs work » Needs review

swentel queued 22: 2295803-helper_for_2287727-22.patch for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
2295803-28.patch561.54 KB

Chasing HEAD

Status: Needs review » Needs work

The last submitted patch, 28: 2295803-28.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
2295803-30.patch494.69 KB

Should be good

Status: Needs review » Needs work

The last submitted patch, 30: 2295803-30.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
2287727-rename_FieldConfig-57.patch561.54 KB

raaaaaah

Status: Needs review » Needs work

The last submitted patch, 32: 2287727-rename_FieldConfig-57.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
FileSize
2295803-32.patch495.15 KB

Was wrong patch - just to be sure ..

swentel’s picture

swentel CreditAttribution: swentel commented
Title: Helper issue for #2287727 - Rename FieldConfig / FieldInstanceConfig » Helper issue for #2287727 - Rename FieldConfig
Status: Needs review » Fixed

Closing this one

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.