How to reproduce: go to /book.
Full error:
Catchable fatal error: Argument 3 passed to l() must be of the type array, null given, called in /var/www/drupal-8/core/modules/book/src/Controller/BookController.php on line 108 and defined in /var/www/drupal-8/core/includes/common.inc on line 830
Call Stack
# Time Memory Function Location
1 0.0003 235144 {main}( ) ../index.php:0
2 0.0010 383800 drupal_handle_request( ) ../index.php:17
3 0.0124 1578128 Drupal\Core\DrupalKernel->handle( ) ../bootstrap.inc:1388
4 0.0143 1767824 Drupal\Core\HttpKernel->handle( ) ../DrupalKernel.php:306
5 0.0144 1769432 Symfony\Component\HttpKernel\HttpKernel->handle( ) ../HttpKernel.php:44
6 0.0144 1769928 Symfony\Component\HttpKernel\HttpKernel->handleRaw( ) ../HttpKernel.php:66
7 0.0320 3885072 call_user_func_array ( ) ../HttpKernel.php:126
8 0.0320 3885544 Drupal\Core\Controller\HtmlPageController->content( ) ../HttpKernel.php:126
9 0.0320 3885640 Drupal\Core\Controller\HtmlPageController->getContentResult( ) ../HtmlPageController.php:53
10 0.0368 4459688 call_user_func_array ( ) ../HtmlPageController.php:76
11 0.0368 4459912 Drupal\book\Controller\BookController->bookRender( ) ../HtmlPageController.php:76
12 0.0483 6261000 l( ) ../BookController.php:108
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | drupal-core-book-fatal-error-2282959-11.patch | 661 bytes | savkaviktor16@gmail.com |
| #2 | drupal-core-book-fatal-error-2282959-2.patch | 674 bytes | pushpinderchauhan |
Comments
Comment #1
pushpinderchauhan commentedComment #2
pushpinderchauhan commentedAdded patch after testing.
Comment #3
primsi commentedLooks good to me.
Comment #4
primsi commentedNow that I think of it. If we had tests for this, it would be even better :)
Comment #5
alexpottYep - we need tests to cover this a prove the issue.
Comment #6
pushpinderchauhan commentedComment #10
lomo commentedI just enabled the book module, created some dummy book pages, put them into a hierarchy and went to /book and got no fatal error. (I also tried, before creating any book pages, and still had no errors). I think this issue is no longer, at least not in the 8.4.x branch.
And if it IS still an issue, then we need to re-roll the patch... I was prepared to sort that out, but it doesn't look like that is necessary...
Comment #11
savkaviktor16@gmail.com commentedre-rolled
Comment #12
dani3lr0se commentedTested with simplytest.me on 8.3.x and can confirm that the patch works. When I navigate to "/books" it shows my books. This could probably be used on 8.5.x as well? I'll try making the patch for 8.5.x., but if someone beats me to it, it's no biggie. Thanks for the help and thanks for this patch. :)
Comment #13
xjmThanks for working on this issue.
What actually needs to happen on this issue is what's described in #10. Rerolling a patch and testing it isn't helpful if there's evidence that the fix is obsolete.
The STR aren't sufficient to produce this error for me. I tried:
So it looks like we need more specific steps to reproduce this problem. There's no need to roll a patch if the issue is not reproducible. And if it still is reproducible, but only under certain circumsrtances, we need to know why. The bug could be in the calling code.
It also needs to have test coverage, as per #5. The test coverage would prove that the bug exists.
Or, if the bug simply does not exist, it can be marked back to "Cannot reproduce".
Comment #14
dani3lr0se commentedThanks for the feedback @xjm. That makes sense. I should've thought about that before reviewing.
Comment #20
ptmkenny commentedClosing this because reading over the issue suggests that the issue was fixed by 8.4.x, and there was no follow-up after #14.